Insufficient space to download does to act properly

i96751414 / plugin.video.torrest

Torrest plugin for Kodi

MIT License

27 stars 6 forks source link

Insufficient space to download does to act properly #9

Open lopezvg opened 3 years ago

lopezvg commented 3 years ago

LOG55579855.log When insufficient space is detected, torrent status should marked as "error", no just "queued", and the Buffer&Play cancelled.

Now it gets blocked at 0% download.

lopezvg commented 3 years ago

In addition, the users tells me that the .torrent contains several files, and although the total size of the files is 7.5GB and there is only 1.5GB. of space available, the user has selected just one file from the torrent list, which is smaller than 1.5GB.

Therefore, Torrest should verify the space available of just the file to download and not for all the files in the torrent.

i96751414 commented 3 years ago

Yep, I have that problem myself when using multiple files torrents. The issue here is that it is only possible to check for the entire torrent space. This is the reason why I added an option to disable the space checking.

Also, at the moment, the daemon set's the torrent as paused when the check fails (making the torrent not able to download), so you should see paused (and not queued). Can you confirm that?

lopezvg commented 3 years ago

I confirm that the torrent is in "Paused" state, but since that is a "non-error" state there is nothing I can do with it.

I see what you say, but from my point o view, for this functionality to be helpful it should meets these criteria:

Do the space check when the file (an not the full torrent) has been selected
I not space is available, the torrent should be moved to a new "error" state
In case of error, the Buffer&Play should be cancelled, stating the reason

It would be best to set this functionality off until is usable.

aicynide commented 9 months ago

@i96751414 you should just use anacrolix/torrent instead which can cache in ram as well as setting limit to disk etc. libtorrent isn't made for streaming remember that

i96751414 commented 9 months ago

I did use anacrolix/torrent a long time ago, however the performance was way inferior at the time. Not sure on how it is at the moment, but I have no plans on changing to it.

icarok99 commented 6 months ago

@i96751414 Which one are you currently using?

Already tested https://github.com/arvidn/libtorrent?

If you update in the future, add options, store in memory and completely download the content.

i96751414 commented 6 months ago

This addon uses torrest wich uses libtorrent. Libtorrent is probably the best lib for torrent right now. Storage in memory is currently not implemented, but I am open for PRs