search

iAM-AMR / sawmill

An R package used to prepare queries from CEDAR (timber) for use in the iAM.AMR models
GNU General Public License v3.0
1 stars 1 forks source link

Usability/Workflow/Meta-Analysis Changes #9

Closed phillipsclynn closed 3 years ago

phillipsclynn commented 3 years ago

Tested with v2 timber.

phillipsclynn commented 3 years ago

@chapb There were initially multiple check_version calls throughout--I have reduced it to one, under start_mill, as I figured that's where us/the users would be changing the default cedar_version if needed. Does that make sense for the workflow or would this ideally be changed somewhere else?

chapb commented 3 years ago

I've looked through the code and the changes look great. And thank you for catching all those rate>prevalence changes, and the documentation formatting. I'm going to merge it in then test,

And yes - that's perfect for the check_version. Ideally, there's not much difference between the two versions once we debark/standardize. I was going to look in more depth to see if we can further reduce the difference in versions; things like column differences can also be fixed by adding columns to old queries.