search

iATSPayments / com.iatspayments.civicrm

CiviCRM Extension supporting iATS Payments services
Other
14 stars 38 forks source link

Edit bubble/notification that pops up when updating card details. #121

Open KarinG opened 8 years ago

tamarmeir commented 8 years ago

Hi Karin,

Was just reading the wiki on the latest features and got a bit lost in what the Edit function will and won't do - not sure if your edit to the bubble is for the same, so I thought I would post here rather than create a new issue.

In https://github.com/iATSPayments/com.iatspayments.civicrm/wiki/Card-on-File#edit, the wiki currently states:

  1. The actual card number field is a bit special: the full number not shown for security reasons. Most of the numbers are obscured with ''. If any of those '' are in your submission, it won't change the card number, so if you just need to edit the expiry date for example without knowing or caring about the number, you can.

I'm good up to here, but then the wiki page ends with:

  1. Specifically - these changes won't change what CiviCRM has saved as the expiry or last four digits [yet].

So, are the changes made in these fields only communicated to iATS where the information is updated, but nothing is changed in the original subscription details as shown in Civi? And when the wiki states:

  1. Most of the time, you'll just want to edit the expiry date and/or the card number, but technically, you could also change to a new card type with a different name on it. These changes won't change anything in CiviCRM, so you may want to consider instead cancelling the recurring contribution sequence and starting a new one.

Is the reason for suggesting to cancel the existing and start a new recurring contribution to avoid confusion between seeing one thing in Civi and another in the iATS merchant portal, but anything changed in this form will be communicated and updated on iATS, so theoretically, subsequent installments will continue to be processed without interruption?

Sorry for not being able to process, it's Monday.

KarinG commented 8 years ago

Exactly - updated card details will process just fine - as the token [that is stored in CiviCRM] has now been connected to the updated card (and iATS knows what that is). We're just not (yet) going back to the CiviCRM table that has the original expiry date and the original last 4 digits stored in it. We're not (yet) replacing that with the new card details. We need to actually swap/move some of that data to a new Table that now exists in CiviCRM. It's on the Todo list!

tamarmeir commented 8 years ago

Perfect - thanks for the clarification and glad to know it is on the to do!

adixon commented 8 years ago

The original issue here (better notification when editing a cc) is still to do, but the editing is now working in 1.5.0 release and also updates the extension copy of the expiry so that will now correctly show.