iAndyHD3
commented
4 months ago First of all, thank you for your work. I'm aware that more actions can be added, but I didn't add them on purpose. The reason is simple, I want the mod to be as easily portable as possible. Using more class members and gd functions means I will need to spend more time looking for the addresses and class members whenever a new update comes out. For example, a new GD update is set to release next week and it will require us to find all new functions and class members.
For that reason, I want to keep a low number of actions and only add ones that are absolutely necessary. The get next free group actions are exactly what I'm talking about, they need class members and they are something that can already be computed using the get level string action, for this reason I want to avoid adding these actions.
However, it might be possible to add some kind of arguments to the get level string action that computes next free groups from the level string itself and then returns it alongside the string (or not), this approach would not have any of the downsides I listed above (besides being obviously slower, as we need to get the entire level string instead of using class members)
That said, I do think there's a place for the get selected objects and the remove selected actions, however some implemention changes are needed.
About the actual code, what kind of errors were you getting and how are you building the mod? I want to avoid adding #include <Geode/Geode.hpp> because that includes every single geode header (that isn't needed) and I want to cut compile time as much as possible.
Moving forward, please remove get groups actions and rename REMOVE_SELECTED to REMOVE_SELECTED_OBJECTS. I will think of adding the next free groups in the level string action as I said above
kxtbit
For a while now, I have been using a custom modified version of this mod that I never published. Now that it was rewritten, I decided to add back my modifications and contribute them here for others to use.
This commit adds four new action types:
GET_SELECTED_OBJECTS(GetSelectedObjects.cpp): Returns the combined object string (separated by;) of all the objects that are selected in the editor.GET_NEXT_FREE_GROUPS(GetNextFreeGroups.cpp): Returns the next free group available in the editor. If the valuecountis specified in the request, it will instead return a list of that many next free groups as a string separated by,.GET_NEXT_FREE_LINKS(GetNextFreeLinks.cpp): Same as the above, but works on link groups instead of normal groups. This has to do with link controls, and is based on the "m_linkedGroup" field of GameObject.REMOVE_SELECTED(RemoveSelected.cpp): Deletes all of the objects that are currently selected by the editor.Other minor modifications are adding
#include <Geode/Geode.hpp>at the top of each code file to resolve a lot of compilation errors I was running into where the compiler was trying to use stubbed headers instead of the real Geode bindings, and changing CMakeLists.txt to usesrc/actions/*.cppto automatically include all of the files in src/actions instead of hardcoding them.I'm not very experienced working with GitHub or contributing to others' code, so please let me know if I've done something wrong :)