search

iAnish / openhab

Automatically exported from code.google.com/p/openhab
GNU General Public License v3.0
0 stars 0 forks source link

Lower logging level of Plugwise Stick to DEBUG #177

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The Plugwise Stick object is generating loads of INFO messages "polluting" the 
console. Can we lower the logging level for this kind of messages:

16:59:57.625 INFO  o.o.b.plugwise.internal.Stick[:398] - Parsing Plugwise 
protocol data unit: command:ACKNOWLEDGEMENT sequence:2261 payload:00C1
16:59:57.625 INFO  o.o.b.plugwise.internal.Stick[:665] - Sending Plugwise 
protocol data unit: attempts: 1 MAC:000D6F0002588B95 
command:POWER_INFORMATION_REQUEST sequence:0 full HEX:0012000D6F00025

Original issue reported on code.google.com by kdekoo...@gmail.com on 6 Jan 2013 at 4:04

GoogleCodeExporter commented 9 years ago

Original comment by kai.openhab on 6 Jan 2013 at 7:56

GoogleCodeExporter commented 9 years ago 
Yes we can

The reason for this extensive logging is that the plugwise protocol 
implementation is the result of reverse engineering efforts and information 
found left and right. I used that level of debugging to verify the behaviour of 
the protocol. Since the protocol itself is incomplete, and might yield funky 
results, I prefer to keep it that way for the time being

K

Original comment by karel.go...@gmail.com on 30 Mar 2013 at 9:55

GoogleCodeExporter commented 9 years ago 
but kind of protocol analyzing could by accomplished by a decent 
log-configuration as well. I'd agree to decrease the level to DEBUG. Goal of 
this issue should be to give to proper log configuration for you to not loose 
information.

I could change level as well but i don't know the right statements to change. 
Do we only talk about the three statements in Stick.java?

Original comment by teichsta on 31 Mar 2013 at 9:54

GoogleCodeExporter commented 9 years ago 
There are also two statements in PlugwiseDevice that might be candidates for 
DEBUG logging.

Original comment by kdekoo...@gmail.com on 31 Mar 2013 at 10:22

GoogleCodeExporter commented 9 years ago 
from my point of view the logging has been decreased - what do you think, 
kdekooter?

Original comment by teichsta on 21 May 2013 at 9:33

GoogleCodeExporter commented 9 years ago 
I don't see any changes to either PlugwiseDevice or Stick when I browse the 
code.

Original comment by kdekoo...@gmail.com on 22 May 2013 at 6:35

GoogleCodeExporter commented 9 years ago 
well, you are right ...

ProTip: check in your Changesets to the default repo if you expect to be part 
of the daily build ;-)

@Karel: since logging could be increased by just adjusting the logback.xml i'd 
prefer to decrease it by default.

Original comment by teichsta on 22 May 2013 at 7:39

GoogleCodeExporter commented 9 years ago 
Looking fine now!

Original comment by kdekoo...@gmail.com on 22 May 2013 at 7:47