iArxic / StudioPresence

Connect your Studio with Discord!
ISC License
24 stars 6 forks source link

feat: project restructure #13

Closed xhayper closed 1 year ago

iArxic commented 1 year ago

Hey @xhayper Could you please explain what are the advantages of this version?

I've seen that the code is more organized DRPC started replaced with StudioPresence started ISC License

What is the 'make it run on push' comment?

xhayper commented 1 year ago

that is related to the ci, what i mean by "make it run on push" is make the ci package the software every time a commit is push to any branch.

xhayper commented 1 year ago

the only software advantage on this version is

that the deprecated function is replaced in the client code ( spawn and wait )

and in the server code there's an additional error check on the JSON.parse line, and on client.clearActivity lines.

xhayper commented 1 year ago

try catch doesn't work on promise.

iArxic commented 1 year ago

looks good, by the way do you know if there is a solution to making the program not be flagged as a virus?

xhayper commented 1 year ago

It have to be signed, which is like 40$ for a license

iArxic commented 1 year ago

thank you for the information, dont think i will be signing it anytime soon haha

i will be pushing v4 later today

xhayper commented 1 year ago

Push it as 3.0.1, follow semver!

iArxic commented 1 year ago

hey sorry for my delays on merging this, i've had projects and i didnt have any time (literally developed till 2am) its fun!! happy new year tho :)

xhayper commented 1 year ago

All good!