search

iBalag / claimant

BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

Configure Github actions to run pytest #9

Closed nchursin closed 2 years ago

nchursin commented 2 years ago

I think it would be nice to cover everything with tests and make the pytest run on PRs. What do you think?

Also, do you mind adding a Pipfile?

iBalag commented 2 years ago

I think it would be nice to cover everything with tests and make the pytest run on PRs. What do you think?

Good point :) But I have not deal with GitHub actions yet ;) If you have relevant experience - feel free to setup it.

do you mind adding a Pipfile?

I thought about it. All my experience say me that pyenv with Pipfile is redundant in this small project. There is not benefit from it, But it takes more actions from developer and more control. It is good for big projects with big team.

nchursin commented 2 years ago

Good point :) But I have not deal with GitHub actions yet ;) If you have relevant experience - feel free to setup it.

Sure, I have some experience, but not with Python. Shouldn't be much different though

I thought about it. All my experience say me that pyenv with Pipfile is redundant in this small project. There is not benefit from it, But it takes more actions from developer and more control. It is good for big projects with big team.

Ok, sounds good. I don't have much experience with Python TBH, more with JS. And this Pipfile looks a lot like package.json, so I though it might be handy. If you think it's an overkill, let's not add that

iBalag commented 2 years ago

Ok, lets focus on GitHub action setup for running tests. Pipfile is redundant here. In python there are no so many dependencies\cross-dependencies like in JS.

nchursin commented 2 years ago

I configured the build to run pytest on pull requests and pushes to main. The config is added to the same PR as the tests, so the build is actually ran for that