search

iBicha / ImageEffectGraph

Image effects for post processing stack created with shader graph for Unity
MIT License
168 stars 18 forks source link

Multiply node breaks the graph #6

Closed merpheus-dev closed 5 years ago

merpheus-dev commented 5 years ago

Unity Version: 2018.3.0b9 When try to connect a multiply node and multiply Maintexture output with color node then assign it image effect node, it doesnt work and become one of "not compiled shaders". Middle of screen became pink with a triangle. (There is a cube over there.) Error like this:

image

Screenshots as follows:

image

image

iBicha commented 5 years ago

Good catch! Thank you for the bug report. This is due to the fact that shader graph expects from the shader generator to implement certain functions, SRGBToLinear being one of them (actually the node requiring this function is the color node, not the multiply one). While SRP (Light weight RP and HDRP) implement this, the legacy shader library doesn't. I'm studying whether this should be implemented separately for each function, or to drop support for legacy graphics at once, since shader graph is supposed to work with SRP. I will try to put a solution in place soon. Thanks

merpheus-dev commented 5 years ago

Interesting, thanks for explanation buddy! You are welcome, I'll be following for updates.

iBicha commented 5 years ago

Hi again! I did work on a work around for this while I was on an airplane and I didn't have internet to push it. Please let me know if the latest version solves the issue

merpheus-dev commented 5 years ago

Sounds good! I'll take a look asap. Although, did you push the latest version 5 days ago ? Because I dont see any new commit.

iBicha commented 5 years ago

Sounds good! I'll take a look asap. Although, did you push the latest version 5 days ago ? Because I dont see any new commit.

Yes in deed, the fix is already pushed

merpheus-dev commented 5 years ago

Hey there! Sorry for it took so long, I was busy with job. So I finally tested it and it looks great! Graph: image Result: image

iBicha commented 5 years ago

Great. Glad this is issue is solved.