search

iBlitzkriegi / Vixio

Vixio, The Skript Addon made to fit all of your Discord needs.
http://www.vixio.space
40 stars 28 forks source link

Used invite expression. #172

Closed gp-Airee closed 5 years ago

gp-Airee commented 5 years ago

Is your feature request related to a problem? Please describe. No.

Describe the solution you'd like I'd really like to have an expression for the invite a user joined with. This can work in the guid join event to allow actions to be run when a user uses a specific invite.

Describe alternatives you've considered I give users a separate code to enter when they've been invited to sync with the server but eeh, that's not great.

Additional context NA.

GamingGeek commented 5 years ago

Discord doesn't give that info. Only way is by using dumb methods so it won't be added

gp-Airee commented 5 years ago

Discord doesn't give that info. Only way is by using dumb methods so it won't be added

How do bots like InviteManager work?

GamingGeek commented 5 years ago

How do bots like InviteManager work?

Only way is by using dumb methods

if you want it so badly, use invitemanager

gp-Airee commented 5 years ago

How do bots like InviteManager work?

Only way is by using dumb methods

if you want it so badly, use invitemanager

I want to automatically run actions when people are invited (i.e. minecraft sync.) If these methods are so "dumb," how can a bot possibly function doing these "dumb methods" on almost 100k guilds?

GamingGeek commented 5 years ago

If these methods are so "dumb," how can a bot possibly function doing these "dumb methods" on almost 100k servers?

because they don't use a minecraft server to host their bot and probably have a database running on a vps that can operate on a large scale. It would be dumb to try and do it on a minecraft server especially if you are also going to have people playing on it alongside running the bot

gp-Airee commented 5 years ago

If these methods are so "dumb," how can a bot possibly function doing these "dumb methods" on almost 100k servers?

because they don't use a minecraft server to host their bot and probably have a database running on a vps that can operate on a large scale. It would be dumb to try and do it on a minecraft server especially if you are also going to have people playing on it alongside running the bot

Could you at least explain what the method is, why it's bad, and why you can definitively state that Vixio will not offer it?

GamingGeek commented 5 years ago

If these methods are so "dumb," how can a bot possibly function doing these "dumb methods" on almost 100k servers?

because they don't use a minecraft server to host their bot and probably have a database running on a vps that can operate on a large scale. It would be dumb to try and do it on a minecraft server especially if you are also going to have people playing on it alongside running the bot

Could you at least explain what the method is, why it's bad, and why you can definitively state that Vixio will not offer it?

It's not bad when you have a vps and a database to run the bot and a database capable of storing all this info. If you really want to do it, you would need to use skript-mirror to access JDA methods to get the invites of a guild, check the usage count against what is already stored in the database and if one has gone up, then you need to check who owns the invite and then do whatever (send a message saying the person joined using the invite, invite use count (and tracking when people leave and deducting a use from the user) etc.), not to mention you would need to do all this inside the on member join guild.

Blitz isn't gonna add all of this to vixio as he would need to add a method of storing invite uses, which would use a lot of storage you might not have or if storing it in memory, a lot of ram you might not have.

Here's a conversation about the exact same thing you want. https://join-the.gaminggeek.club/images/4c4umu34.png

Pikachu920 commented 5 years ago

@GamingGeek https://github.com/discordapp/discord-api-docs/issues/448

Discord plans to add this, so nothing wrong with this issue sticking around here till then

gp-Airee commented 5 years ago

Don't think Discord will be adding it in the immediate future. How difficult on resources could it be to cache all the invites, listen for Discord joins, immediately save the caches state and check which invite code was used based on number of uses. Storing basic data like that uses nowhere as much storage as you seem to make it out to use. A file of 1500 lines of 8 char. random generated strings is under 15KB Adding invite numbers to it wouldn't cost much. You don't need an amazing database server or anything to store this kind of data. This kind of data could EASILY be stored in RAM on a server of basically any scale. If it's too much somehow, a configuration toggle would be great. Doesn't even need to default to enabled.

Syst3ms commented 5 years ago

The question here is not whether Discord should add it or not, it's whether it should be added in here if Discord adds it. The answer is yes.

GamingGeek commented 5 years ago

The question here is not whether Discord should add it or not

ok? we all know that. that was never the question here

Syst3ms commented 5 years ago

ok? we all know that. that was never the question here

I kinda missed @Fiiily's point, actually

gp-Airee commented 5 years ago

The question here is not whether Discord should add it or not, it's whether it should be added in here if Discord adds it. The answer is yes.

I'm saying that it wouldn't be intensive to implement that on the end of Vixio.

GamingGeek commented 5 years ago

@Fiiily If it gets added officially to discord, I see no reason for it not to be added but any weird methods like I previously explained wouldn't get added

iBlitzkriegi commented 5 years ago

This still has yet to be implemented by Discord. If it's ever added feel free to re-open this issue.