search

iBotPeaches / Apktool

A tool for reverse engineering Android apk files
https://apktool.org/
Apache License 2.0
20.29k stars 3.59k forks source link

"Multiple substitutions specified in non-positional format" when recompiling most recent Facebook APK (decode/build without any changes) #1405

Closed evilwombat closed 7 years ago

evilwombat commented 7 years ago

Information

  1. Apktool Version (apktool -version) - 2.2.1
  2. Operating System (Mac, Linux, Windows) - Linux x86_64
  3. APK From? (Playstore, ROM, Other) - Playstore

Stacktrace/Logcat

I: Using Apktool 2.2.1
I: Checking whether resources has changed...
I: Building resources...
W: /tmp/fb/res/values/plurals.xml:641: error: Multiple substitutions specified in non-positional format; did you mean to add the formatted="false" attribute?
W: 
W: /tmp/fb/res/values/plurals.xml:641: error: Found tag < /item> where < /plurals> is expected
W: 
W: /tmp/fb/res/values/public.xml:59831: error: Public symbol plurals/APKTOOL_DUMMY_1 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59834: error: Public symbol plurals/APKTOOL_DUMMY_10 declared here is not defined.
[ lots more of the same ]

Exception in thread "main" brut.androlib.AndrolibException: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_6268856882445229759.tmp, p, --forced-package-id, 127, --min-sdk-version, 15, --target-sdk-version, 23, --version-code, 45904150, --version-name, 106.0.0.26.68, -F, /tmp/APKTOOL111372006669487626.tmp, -0, arsc, -0, FBSIG, -0, assets/ComponentScriptBundle.js.meta, -0, assets/InboxV2Query_MessengerInboxUnits_Nodes.fbs.md5, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui-1.dex.jar.xzs.tmp~.meta, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui.dex.jar.xzs, -0, js, -0, assets/js-modules/UNBUNDLE, -0, xzs, -0, assets/secondary-program-dex-jars/secondary-2.dex.jar.xzs.tmp~.meta, -0, assets/secondary-program-dex-jars/secondary.dex.jar.xzs, -0, arsc, -I, /home/steve/.local/share/apktool/framework/1.apk, -S, /tmp/fb/res, -M, /tmp/fb/AndroidManifest.xml]
    at brut.androlib.Androlib.buildResourcesFull(Androlib.java:478)
    at brut.androlib.Androlib.buildResources(Androlib.java:412)
    at brut.androlib.Androlib.build(Androlib.java:311)
    at brut.androlib.Androlib.build(Androlib.java:264)
    at brut.apktool.Main.cmdBuild(Main.java:227)
    at brut.apktool.Main.main(Main.java:84)
Caused by: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_6268856882445229759.tmp, p, --forced-package-id, 127, --min-sdk-version, 15, --target-sdk-version, 23, --version-code, 45904150, --version-name, 106.0.0.26.68, -F, /tmp/APKTOOL111372006669487626.tmp, -0, arsc, -0, FBSIG, -0, assets/ComponentScriptBundle.js.meta, -0, assets/InboxV2Query_MessengerInboxUnits_Nodes.fbs.md5, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui-1.dex.jar.xzs.tmp~.meta, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui.dex.jar.xzs, -0, js, -0, assets/js-modules/UNBUNDLE, -0, xzs, -0, assets/secondary-program-dex-jars/secondary-2.dex.jar.xzs.tmp~.meta, -0, assets/secondary-program-dex-jars/secondary.dex.jar.xzs, -0, arsc, -I, /home/steve/.local/share/apktool/framework/1.apk, -S, /tmp/fb/res, -M, /tmp/fb/AndroidManifest.xml]
    at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:439)
    at brut.androlib.Androlib.buildResourcesFull(Androlib.java:464)
    ... 5 more
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_6268856882445229759.tmp, p, --forced-package-id, 127, --min-sdk-version, 15, --target-sdk-version, 23, --version-code, 45904150, --version-name, 106.0.0.26.68, -F, /tmp/APKTOOL111372006669487626.tmp, -0, arsc, -0, FBSIG, -0, assets/ComponentScriptBundle.js.meta, -0, assets/InboxV2Query_MessengerInboxUnits_Nodes.fbs.md5, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui-1.dex.jar.xzs.tmp~.meta, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui.dex.jar.xzs, -0, js, -0, assets/js-modules/UNBUNDLE, -0, xzs, -0, assets/secondary-program-dex-jars/secondary-2.dex.jar.xzs.tmp~.meta, -0, assets/secondary-program-dex-jars/secondary.dex.jar.xzs, -0, arsc, -I, /home/steve/.local/share/apktool/framework/1.apk, -S, /tmp/fb/res, -M, /tmp/fb/AndroidManifest.xml]
    at brut.util.OS.exec(OS.java:95)
    at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:433)
    ... 6 more

Steps to Reproduce

  1. apktool d facebook.apk -s -f -o /tmp/fb/
  2. (make no changes)
  3. apktool b /tmp/fb/ -o /tmp/facebook.apk

This worked fine for a prior version of the application I am patching, but does not work with the most recent version. The problem does not happen when using apktool d -r, but one of the things I want to change are the resources (only a small part of what I want to accomplish can be done by DEX patching).

APK

This is plain vanilla Facebook for Android, available on the Play Store as com.facebook.katana. Here's an APK file to save you the trouble. https://www.dropbox.com/s/kkaaterp0eapen9/fb.apk?dl=0

Questions to ask before submission

  1. Have you tried apktool d, apktool b without changing anything? Yeah
  2. If you are trying to install a modified apk, did you resign it? N/A
  3. Are you using the latest apktool version? Yeah

Thanks!

evilwombat commented 7 years ago

This is preceded by a bunch of resource-related errors. Executing the failed command manually yields the same error output. I guess the exec error refers to the error in resource building. Here's the full error output.

java -jar apktool/apktool_2.2.1.jar b /tmp/fb -o /tmp/fb.apk
I: Using Apktool 2.2.1
I: Checking whether resources has changed...
I: Building resources...
W: /tmp/fb/res/values/plurals.xml:641: error: Multiple substitutions specified in non-positional format; did you mean to add the formatted="false" attribute?
W: 
W: /tmp/fb/res/values/plurals.xml:641: error: Found tag </item> where </plurals> is expected
W: 
W: /tmp/fb/res/values/public.xml:59831: error: Public symbol plurals/APKTOOL_DUMMY_1 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59834: error: Public symbol plurals/APKTOOL_DUMMY_10 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59892: error: Public symbol plurals/APKTOOL_DUMMY_102 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59893: error: Public symbol plurals/APKTOOL_DUMMY_10a declared here is not defined.
W: /tmp/fb/res/values/public.xml:59894: error: Public symbol plurals/APKTOOL_DUMMY_10b declared here is not defined.
W: /tmp/fb/res/values/public.xml:59895: error: Public symbol plurals/APKTOOL_DUMMY_110 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59896: error: Public symbol plurals/APKTOOL_DUMMY_111 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59897: error: Public symbol plurals/APKTOOL_DUMMY_112 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59898: error: Public symbol plurals/APKTOOL_DUMMY_119 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59899: error: Public symbol plurals/APKTOOL_DUMMY_11a declared here is not defined.
W: /tmp/fb/res/values/public.xml:59900: error: Public symbol plurals/APKTOOL_DUMMY_11c declared here is not defined.
W: /tmp/fb/res/values/public.xml:59901: error: Public symbol plurals/APKTOOL_DUMMY_11d declared here is not defined.
W: /tmp/fb/res/values/public.xml:59902: error: Public symbol plurals/APKTOOL_DUMMY_11e declared here is not defined.
W: /tmp/fb/res/values/public.xml:59903: error: Public symbol plurals/APKTOOL_DUMMY_11f declared here is not defined.
W: /tmp/fb/res/values/public.xml:59904: error: Public symbol plurals/APKTOOL_DUMMY_120 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59905: error: Public symbol plurals/APKTOOL_DUMMY_121 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59906: error: Public symbol plurals/APKTOOL_DUMMY_135 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59907: error: Public symbol plurals/APKTOOL_DUMMY_13b declared here is not defined.
W: /tmp/fb/res/values/public.xml:59908: error: Public symbol plurals/APKTOOL_DUMMY_140 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59909: error: Public symbol plurals/APKTOOL_DUMMY_141 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59910: error: Public symbol plurals/APKTOOL_DUMMY_147 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59911: error: Public symbol plurals/APKTOOL_DUMMY_148 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59912: error: Public symbol plurals/APKTOOL_DUMMY_149 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59913: error: Public symbol plurals/APKTOOL_DUMMY_14c declared here is not defined.
W: /tmp/fb/res/values/public.xml:59914: error: Public symbol plurals/APKTOOL_DUMMY_14f declared here is not defined.
W: /tmp/fb/res/values/public.xml:59915: error: Public symbol plurals/APKTOOL_DUMMY_151 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59916: error: Public symbol plurals/APKTOOL_DUMMY_169 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59917: error: Public symbol plurals/APKTOOL_DUMMY_183 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59918: error: Public symbol plurals/APKTOOL_DUMMY_184 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59919: error: Public symbol plurals/APKTOOL_DUMMY_186 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59920: error: Public symbol plurals/APKTOOL_DUMMY_187 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59921: error: Public symbol plurals/APKTOOL_DUMMY_18a declared here is not defined.
W: /tmp/fb/res/values/public.xml:59922: error: Public symbol plurals/APKTOOL_DUMMY_18f declared here is not defined.
W: /tmp/fb/res/values/public.xml:59923: error: Public symbol plurals/APKTOOL_DUMMY_190 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59924: error: Public symbol plurals/APKTOOL_DUMMY_191 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59925: error: Public symbol plurals/APKTOOL_DUMMY_192 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59926: error: Public symbol plurals/APKTOOL_DUMMY_193 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59927: error: Public symbol plurals/APKTOOL_DUMMY_194 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59835: error: Public symbol plurals/APKTOOL_DUMMY_1e declared here is not defined.
W: /tmp/fb/res/values/public.xml:59836: error: Public symbol plurals/APKTOOL_DUMMY_21 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59837: error: Public symbol plurals/APKTOOL_DUMMY_22 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59838: error: Public symbol plurals/APKTOOL_DUMMY_23 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59839: error: Public symbol plurals/APKTOOL_DUMMY_36 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59840: error: Public symbol plurals/APKTOOL_DUMMY_37 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59841: error: Public symbol plurals/APKTOOL_DUMMY_38 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59842: error: Public symbol plurals/APKTOOL_DUMMY_39 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59843: error: Public symbol plurals/APKTOOL_DUMMY_41 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59844: error: Public symbol plurals/APKTOOL_DUMMY_42 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59845: error: Public symbol plurals/APKTOOL_DUMMY_4c declared here is not defined.
W: /tmp/fb/res/values/public.xml:59846: error: Public symbol plurals/APKTOOL_DUMMY_4f declared here is not defined.
W: /tmp/fb/res/values/public.xml:59847: error: Public symbol plurals/APKTOOL_DUMMY_50 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59848: error: Public symbol plurals/APKTOOL_DUMMY_53 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59849: error: Public symbol plurals/APKTOOL_DUMMY_54 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59850: error: Public symbol plurals/APKTOOL_DUMMY_55 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59851: error: Public symbol plurals/APKTOOL_DUMMY_57 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59852: error: Public symbol plurals/APKTOOL_DUMMY_58 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59853: error: Public symbol plurals/APKTOOL_DUMMY_5d declared here is not defined.
W: /tmp/fb/res/values/public.xml:59854: error: Public symbol plurals/APKTOOL_DUMMY_65 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59855: error: Public symbol plurals/APKTOOL_DUMMY_67 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59856: error: Public symbol plurals/APKTOOL_DUMMY_6a declared here is not defined.
W: /tmp/fb/res/values/public.xml:59857: error: Public symbol plurals/APKTOOL_DUMMY_6b declared here is not defined.
W: /tmp/fb/res/values/public.xml:59858: error: Public symbol plurals/APKTOOL_DUMMY_6c declared here is not defined.
W: /tmp/fb/res/values/public.xml:59859: error: Public symbol plurals/APKTOOL_DUMMY_6e declared here is not defined.
W: /tmp/fb/res/values/public.xml:59860: error: Public symbol plurals/APKTOOL_DUMMY_74 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59861: error: Public symbol plurals/APKTOOL_DUMMY_75 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59862: error: Public symbol plurals/APKTOOL_DUMMY_76 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59863: error: Public symbol plurals/APKTOOL_DUMMY_77 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59864: error: Public symbol plurals/APKTOOL_DUMMY_7a declared here is not defined.
W: /tmp/fb/res/values/public.xml:59865: error: Public symbol plurals/APKTOOL_DUMMY_7b declared here is not defined.
W: /tmp/fb/res/values/public.xml:59866: error: Public symbol plurals/APKTOOL_DUMMY_81 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59867: error: Public symbol plurals/APKTOOL_DUMMY_83 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59868: error: Public symbol plurals/APKTOOL_DUMMY_8b declared here is not defined.
W: /tmp/fb/res/values/public.xml:59869: error: Public symbol plurals/APKTOOL_DUMMY_90 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59870: error: Public symbol plurals/APKTOOL_DUMMY_a1 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59871: error: Public symbol plurals/APKTOOL_DUMMY_a2 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59872: error: Public symbol plurals/APKTOOL_DUMMY_a9 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59873: error: Public symbol plurals/APKTOOL_DUMMY_aa declared here is not defined.
W: /tmp/fb/res/values/public.xml:59874: error: Public symbol plurals/APKTOOL_DUMMY_ab declared here is not defined.
W: /tmp/fb/res/values/public.xml:59875: error: Public symbol plurals/APKTOOL_DUMMY_ac declared here is not defined.
W: /tmp/fb/res/values/public.xml:59876: error: Public symbol plurals/APKTOOL_DUMMY_ad declared here is not defined.
W: /tmp/fb/res/values/public.xml:59877: error: Public symbol plurals/APKTOOL_DUMMY_ae declared here is not defined.
W: /tmp/fb/res/values/public.xml:59878: error: Public symbol plurals/APKTOOL_DUMMY_af declared here is not defined.
W: /tmp/fb/res/values/public.xml:59879: error: Public symbol plurals/APKTOOL_DUMMY_b2 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59880: error: Public symbol plurals/APKTOOL_DUMMY_b3 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59881: error: Public symbol plurals/APKTOOL_DUMMY_b4 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59882: error: Public symbol plurals/APKTOOL_DUMMY_c5 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59883: error: Public symbol plurals/APKTOOL_DUMMY_c8 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59884: error: Public symbol plurals/APKTOOL_DUMMY_c9 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59885: error: Public symbol plurals/APKTOOL_DUMMY_d5 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59886: error: Public symbol plurals/APKTOOL_DUMMY_db declared here is not defined.
W: /tmp/fb/res/values/public.xml:59887: error: Public symbol plurals/APKTOOL_DUMMY_dc declared here is not defined.
W: /tmp/fb/res/values/public.xml:59832: error: Public symbol plurals/APKTOOL_DUMMY_e declared here is not defined.
W: /tmp/fb/res/values/public.xml:59888: error: Public symbol plurals/APKTOOL_DUMMY_e9 declared here is not defined.
W: /tmp/fb/res/values/public.xml:59833: error: Public symbol plurals/APKTOOL_DUMMY_f declared here is not defined.
W: /tmp/fb/res/values/public.xml:59889: error: Public symbol plurals/APKTOOL_DUMMY_fd declared here is not defined.
W: /tmp/fb/res/values/public.xml:59890: error: Public symbol plurals/APKTOOL_DUMMY_fe declared here is not defined.
W: /tmp/fb/res/values/public.xml:59891: error: Public symbol plurals/APKTOOL_DUMMY_ff declared here is not defined.
W: /tmp/fb/res/values/public.xml:59747: error: Public symbol plurals/accessible_generic_bookmark_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59736: error: Public symbol plurals/add_to_groups_exit_dialog_message declared here is not defined.
W: /tmp/fb/res/values/public.xml:59742: error: Public symbol plurals/attachment_description_num_people declared here is not defined.
W: /tmp/fb/res/values/public.xml:59743: error: Public symbol plurals/attachment_description_num_places declared here is not defined.
W: /tmp/fb/res/values/public.xml:59731: error: Public symbol plurals/awesomizer_number_of_stories declared here is not defined.
W: /tmp/fb/res/values/public.xml:59751: error: Public symbol plurals/backstage_upload_confirmation_sending declared here is not defined.
W: /tmp/fb/res/values/public.xml:59752: error: Public symbol plurals/backstage_upload_confirmation_sent declared here is not defined.
W: /tmp/fb/res/values/public.xml:59759: error: Public symbol plurals/booking_notification_banner_number_of_appointment_requests declared here is not defined.
W: /tmp/fb/res/values/public.xml:59760: error: Public symbol plurals/booking_notification_banner_number_of_appointments declared here is not defined.
W: /tmp/fb/res/values/public.xml:59819: error: Public symbol plurals/cart_item_quantity_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59821: error: Public symbol plurals/composer_collage_tag_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59716: error: Public symbol plurals/compost_snackbar_message declared here is not defined.
W: /tmp/fb/res/values/public.xml:59763: error: Public symbol plurals/contact_upload_success_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59825: error: Public symbol plurals/contacts_upload_notification_message declared here is not defined.
W: /tmp/fb/res/values/public.xml:59824: error: Public symbol plurals/contacts_upload_notification_title declared here is not defined.
W: /tmp/fb/res/values/public.xml:59822: error: Public symbol plurals/cymk_mutual_contacts_label declared here is not defined.
W: /tmp/fb/res/values/public.xml:59711: error: Public symbol plurals/default_story_text_error_uploading declared here is not defined.
W: /tmp/fb/res/values/public.xml:59709: error: Public symbol plurals/default_story_text_uploading_photos declared here is not defined.
W: /tmp/fb/res/values/public.xml:59710: error: Public symbol plurals/default_story_text_waiting_to_upload declared here is not defined.
W: /tmp/fb/res/values/public.xml:59753: error: Public symbol plurals/device_request declared here is not defined.
W: /tmp/fb/res/values/public.xml:59754: error: Public symbol plurals/device_requests_awaiting_approval declared here is not defined.
W: /tmp/fb/res/values/public.xml:59715: error: Public symbol plurals/drafts_header_description declared here is not defined.
W: /tmp/fb/res/values/public.xml:59691: error: Public symbol plurals/event_admin_review_posts_status declared here is not defined.
W: /tmp/fb/res/values/public.xml:59693: error: Public symbol plurals/event_artist_num_likes declared here is not defined.
W: /tmp/fb/res/values/public.xml:59692: error: Public symbol plurals/event_attendee_review_posts_status declared here is not defined.
W: /tmp/fb/res/values/public.xml:59696: error: Public symbol plurals/event_buy_tickets_num_tickets declared here is not defined.
W: /tmp/fb/res/values/public.xml:59697: error: Public symbol plurals/event_buy_tickets_num_tickets_with_tier_name declared here is not defined.
W: /tmp/fb/res/values/public.xml:59722: error: Public symbol plurals/event_invites_count_accessibility_label declared here is not defined.
W: /tmp/fb/res/values/public.xml:59694: error: Public symbol plurals/event_location_sharing_title declared here is not defined.
W: /tmp/fb/res/values/public.xml:59762: error: Public symbol plurals/event_reminder_users_cant_go_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59761: error: Public symbol plurals/event_reminder_users_going_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59772: error: Public symbol plurals/event_social_context_friends_going_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59773: error: Public symbol plurals/event_social_context_friends_interested_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59774: error: Public symbol plurals/event_social_context_friends_maybe_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59823: error: Public symbol plurals/event_social_context_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59699: error: Public symbol plurals/event_ticket_confirmation_view_ticket_order_action_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59698: error: Public symbol plurals/event_ticket_order_title_without_ticket_tier declared here is not defined.
W: /tmp/fb/res/values/public.xml:59718: error: Public symbol plurals/events_cohosts_social_string declared here is not defined.
W: /tmp/fb/res/values/public.xml:59719: error: Public symbol plurals/events_dashboard_birthday_friend_age declared here is not defined.
W: /tmp/fb/res/values/public.xml:59720: error: Public symbol plurals/events_dashboard_birthday_friend_age_future declared here is not defined.
W: /tmp/fb/res/values/public.xml:59721: error: Public symbol plurals/events_dashboard_birthday_friend_age_recent declared here is not defined.
W: /tmp/fb/res/values/public.xml:59813: error: Public symbol plurals/events_discovery_location_range_n_miles declared here is not defined.
W: /tmp/fb/res/values/public.xml:59814: error: Public symbol plurals/events_discovery_n_category_filters declared here is not defined.
W: /tmp/fb/res/values/public.xml:59690: error: Public symbol plurals/events_guestlist_mutual_friends declared here is not defined.
W: /tmp/fb/res/values/public.xml:59689: error: Public symbol plurals/events_guestlist_title_with_count_declined declared here is not defined.
W: /tmp/fb/res/values/public.xml:59686: error: Public symbol plurals/events_guestlist_title_with_count_going declared here is not defined.
W: /tmp/fb/res/values/public.xml:59688: error: Public symbol plurals/events_guestlist_title_with_count_invited declared here is not defined.
W: /tmp/fb/res/values/public.xml:59687: error: Public symbol plurals/events_guestlist_title_with_count_maybe declared here is not defined.
W: /tmp/fb/res/values/public.xml:59695: error: Public symbol plurals/events_message_guest_count_warning_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59681: error: Public symbol plurals/events_permalink_guest_summary_going_long_with_others declared here is not defined.
W: /tmp/fb/res/values/public.xml:59682: error: Public symbol plurals/events_permalink_guest_summary_going_short declared here is not defined.
W: /tmp/fb/res/values/public.xml:59683: error: Public symbol plurals/events_permalink_guest_summary_maybe_long_with_others declared here is not defined.
W: /tmp/fb/res/values/public.xml:59684: error: Public symbol plurals/events_permalink_guest_summary_maybe_short declared here is not defined.
W: /tmp/fb/res/values/public.xml:59685: error: Public symbol plurals/events_permalink_host_or_artist_and_others declared here is not defined.
W: /tmp/fb/res/values/public.xml:59775: error: Public symbol plurals/events_purchased_tickets_social_context declared here is not defined.
W: /tmp/fb/res/values/public.xml:59807: error: Public symbol plurals/events_social_context_going_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59809: error: Public symbol plurals/events_social_context_hosting_past_public_event_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59812: error: Public symbol plurals/events_social_context_hosting_tab_event_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59808: error: Public symbol plurals/events_social_context_interested_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59811: error: Public symbol plurals/events_social_context_past_attended_event_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59810: error: Public symbol plurals/events_social_context_past_private_event_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59806: error: Public symbol plurals/events_social_context_tickets_bought declared here is not defined.
W: /tmp/fb/res/values/public.xml:59703: error: Public symbol plurals/events_time_hours_ago declared here is not defined.
W: /tmp/fb/res/values/public.xml:59702: error: Public symbol plurals/events_time_hours_from_now declared here is not defined.
W: /tmp/fb/res/values/public.xml:59701: error: Public symbol plurals/events_time_minutes_ago declared here is not defined.
W: /tmp/fb/res/values/public.xml:59700: error: Public symbol plurals/events_time_minutes_from_now declared here is not defined.
W: /tmp/fb/res/values/public.xml:59707: error: Public symbol plurals/events_time_months_ago declared here is not defined.
W: /tmp/fb/res/values/public.xml:59706: error: Public symbol plurals/events_time_months_from_now declared here is not defined.
W: /tmp/fb/res/values/public.xml:59705: error: Public symbol plurals/events_time_weeks_ago declared here is not defined.
W: /tmp/fb/res/values/public.xml:59704: error: Public symbol plurals/events_time_weeks_from_now declared here is not defined.
W: /tmp/fb/res/values/public.xml:59797: error: Public symbol plurals/friend_finder_all_done declared here is not defined.
W: /tmp/fb/res/values/public.xml:59741: error: Public symbol plurals/friend_vote_invite_dialog_description declared here is not defined.
W: /tmp/fb/res/values/public.xml:59740: error: Public symbol plurals/friend_vote_invite_dialog_title declared here is not defined.
W: /tmp/fb/res/values/public.xml:59815: error: Public symbol plurals/friendlist_discovery_entry_point_subtitle_friends_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59816: error: Public symbol plurals/friends_nearby_dashboard_incoming_ping_section_title declared here is not defined.
W: /tmp/fb/res/values/public.xml:59794: error: Public symbol plurals/fundraiser_beneficiary_other_input_char_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59750: error: Public symbol plurals/fundraiser_bookmark_invite_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59795: error: Public symbol plurals/fundraiser_guestlist_mutual_friends declared here is not defined.
W: /tmp/fb/res/values/public.xml:59799: error: Public symbol plurals/gametime_fan_favorite_total_picks declared here is not defined.
W: /tmp/fb/res/values/public.xml:59733: error: Public symbol plurals/goodfriends_audience_x_friends_to_have_more_fun_title declared here is not defined.
W: /tmp/fb/res/values/public.xml:59732: error: Public symbol plurals/goodfriends_confirm_x_friends declared here is not defined.
W: /tmp/fb/res/values/public.xml:59739: error: Public symbol plurals/graph_editor_scoreboard_points declared here is not defined.
W: /tmp/fb/res/values/public.xml:59777: error: Public symbol plurals/group_event_friends_going_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59776: error: Public symbol plurals/group_event_friends_maybe_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59817: error: Public symbol plurals/group_photos_x_photos_in_album declared here is not defined.
W: /tmp/fb/res/values/public.xml:59786: error: Public symbol plurals/groups_member_of_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59787: error: Public symbol plurals/groups_member_requests_mutual_friends_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59791: error: Public symbol plurals/gysc_item_friend_count_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59744: error: Public symbol plurals/hot_conversations_social_context_one_important_others declared here is not defined.
W: /tmp/fb/res/values/public.xml:59745: error: Public symbol plurals/hot_conversations_social_context_two_important_others declared here is not defined.
W: /tmp/fb/res/values/public.xml:59748: error: Public symbol plurals/instagram_bookmark_friends_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59749: error: Public symbol plurals/instagram_bookmark_unseen_notification_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59735: error: Public symbol plurals/inventory_notifier_message declared here is not defined.
W: /tmp/fb/res/values/public.xml:59830: error: Public symbol plurals/live_map_video_viewers declared here is not defined.
W: /tmp/fb/res/values/public.xml:59723: error: Public symbol plurals/local_serps_reviews_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59734: error: Public symbol plurals/media_picker_album_description declared here is not defined.
W: /tmp/fb/res/values/public.xml:59779: error: Public symbol plurals/member_picker_add_members_fail_dialog_message_with_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59781: error: Public symbol plurals/member_picker_added_complete declared here is not defined.
W: /tmp/fb/res/values/public.xml:59780: error: Public symbol plurals/member_picker_added_partial declared here is not defined.
W: /tmp/fb/res/values/public.xml:59784: error: Public symbol plurals/member_picker_admin_approval declared here is not defined.
W: /tmp/fb/res/values/public.xml:59778: error: Public symbol plurals/member_picker_blocking_inviting_dialog_message_with_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59783: error: Public symbol plurals/member_picker_invited_complete declared here is not defined.
W: /tmp/fb/res/values/public.xml:59782: error: Public symbol plurals/member_picker_invited_partial declared here is not defined.
W: /tmp/fb/res/values/public.xml:59785: error: Public symbol plurals/memberrequests_friends_in_group_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59796: error: Public symbol plurals/message_guest_count_warning_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59829: error: Public symbol plurals/msgr_rooms_friend_joined_shortened declared here is not defined.
W: /tmp/fb/res/values/public.xml:59755: error: Public symbol plurals/msgr_rooms_member_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59717: error: Public symbol plurals/nearby_places_n_other_friends declared here is not defined.
W: /tmp/fb/res/values/public.xml:59820: error: Public symbol plurals/new_friend_requests_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59729: error: Public symbol plurals/num_results declared here is not defined.
W: /tmp/fb/res/values/public.xml:59804: error: Public symbol plurals/number_of_positions_available declared here is not defined.
W: /tmp/fb/res/values/public.xml:59828: error: Public symbol plurals/orca_switch_accounts_last_logged_in_days declared here is not defined.
W: /tmp/fb/res/values/public.xml:59827: error: Public symbol plurals/orca_switch_accounts_last_logged_in_hours declared here is not defined.
W: /tmp/fb/res/values/public.xml:59826: error: Public symbol plurals/orca_switch_accounts_last_logged_in_minutes declared here is not defined.
W: /tmp/fb/res/values/public.xml:59788: error: Public symbol plurals/page_events_list_num_subscribers declared here is not defined.
W: /tmp/fb/res/values/public.xml:59818: error: Public symbol plurals/pages_browser_likes_with_number declared here is not defined.
W: /tmp/fb/res/values/public.xml:59789: error: Public symbol plurals/pages_launchpoint_pending_invites_likes_with_number declared here is not defined.
W: /tmp/fb/res/values/public.xml:59764: error: Public symbol plurals/post_photos declared here is not defined.
W: /tmp/fb/res/values/public.xml:59724: error: Public symbol plurals/pulse_common_phrases_mentions_sentence declared here is not defined.
W: /tmp/fb/res/values/public.xml:59725: error: Public symbol plurals/pulse_related_links_shares_sentence declared here is not defined.
W: /tmp/fb/res/values/public.xml:59758: error: Public symbol plurals/received_requests_banner_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59730: error: Public symbol plurals/recent_search_new_posts declared here is not defined.
W: /tmp/fb/res/values/public.xml:59800: error: Public symbol plurals/sc_inner_last_used declared here is not defined.
W: /tmp/fb/res/values/public.xml:59728: error: Public symbol plurals/search_result_birthday_days_remaining declared here is not defined.
W: /tmp/fb/res/values/public.xml:59727: error: Public symbol plurals/search_result_time_delta_negative declared here is not defined.
W: /tmp/fb/res/values/public.xml:59726: error: Public symbol plurals/search_result_time_delta_positive declared here is not defined.
W: /tmp/fb/res/values/public.xml:59802: error: Public symbol plurals/selfupdate_cancel_dialog_text_alt declared here is not defined.
W: /tmp/fb/res/values/public.xml:59801: error: Public symbol plurals/selfupdate_minutes_left declared here is not defined.
W: /tmp/fb/res/values/public.xml:59770: error: Public symbol plurals/sell_composer_audience_other_groups declared here is not defined.
W: /tmp/fb/res/values/public.xml:59771: error: Public symbol plurals/sell_composer_audience_other_places declared here is not defined.
W: /tmp/fb/res/values/public.xml:59757: error: Public symbol plurals/sent_appointments_banner_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59790: error: Public symbol plurals/snacks_my_story_view_count declared here is not defined.
W: /tmp/fb/res/values/public.xml:59712: error: Public symbol plurals/story_draft_expiration_days declared here is not defined.
W: /tmp/fb/res/values/public.xml:59713: error: Public symbol plurals/story_draft_expiration_hours declared here is not defined.
W: /tmp/fb/res/values/public.xml:59714: error: Public symbol plurals/story_draft_expiration_minutes declared here is not defined.
W: /tmp/fb/res/values/public.xml:59738: error: Public symbol plurals/suggest_edits_pending_edits_banner declared here is not defined.
W: /tmp/fb/res/values/public.xml:59792: error: Public symbol plurals/throwback_friendversary_friends_on_this_day_qty declared here is not defined.
W: /tmp/fb/res/values/public.xml:59746: error: Public symbol plurals/throwback_years_ago_plural declared here is not defined.
W: /tmp/fb/res/values/public.xml:59708: error: Public symbol plurals/timeline_new_posts declared here is not defined.
W: /tmp/fb/res/values/public.xml:59768: error: Public symbol plurals/top_sms_contacts_start_conversations_none_selected declared here is not defined.
W: /tmp/fb/res/values/public.xml:59769: error: Public symbol plurals/top_sms_contacts_start_conversations_with_number declared here is not defined.
W: /tmp/fb/res/values/public.xml:59766: error: Public symbol plurals/top_sms_matched_picker_all_matched_title_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59767: error: Public symbol plurals/top_sms_matched_picker_header_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59765: error: Public symbol plurals/top_sms_matched_picker_title_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59803: error: Public symbol plurals/topic_featuring_stories_and_n_other_sources declared here is not defined.
W: /tmp/fb/res/values/public.xml:59793: error: Public symbol plurals/unread_threads_diode_title declared here is not defined.
W: /tmp/fb/res/values/public.xml:59756: error: Public symbol plurals/upcoming_appointments_banner_text declared here is not defined.
W: /tmp/fb/res/values/public.xml:59737: error: Public symbol plurals/upload_place_photo_finished_message declared here is not defined.
W: /tmp/fb/res/values/public.xml:59805: error: Public symbol plurals/work_group_tab_list_item_posts_count_subtitle declared here is not defined.
Exception in thread "main" brut.androlib.AndrolibException: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_1366314752908978208.tmp, p, --forced-package-id, 127, --min-sdk-version, 15, --target-sdk-version, 23, --version-code, 45904150, --version-name, 106.0.0.26.68, -F, /tmp/APKTOOL1488854893565011040.tmp, -0, arsc, -0, FBSIG, -0, assets/ComponentScriptBundle.js.meta, -0, assets/InboxV2Query_MessengerInboxUnits_Nodes.fbs.md5, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui-1.dex.jar.xzs.tmp~.meta, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui.dex.jar.xzs, -0, js, -0, assets/js-modules/UNBUNDLE, -0, xzs, -0, assets/secondary-program-dex-jars/secondary-2.dex.jar.xzs.tmp~.meta, -0, assets/secondary-program-dex-jars/secondary.dex.jar.xzs, -0, arsc, -I, /home/steve/.local/share/apktool/framework/1.apk, -S, /tmp/fb/res, -M, /tmp/fb/AndroidManifest.xml]
    at brut.androlib.Androlib.buildResourcesFull(Androlib.java:478)
    at brut.androlib.Androlib.buildResources(Androlib.java:412)
    at brut.androlib.Androlib.build(Androlib.java:311)
    at brut.androlib.Androlib.build(Androlib.java:264)
    at brut.apktool.Main.cmdBuild(Main.java:227)
    at brut.apktool.Main.main(Main.java:84)
Caused by: brut.androlib.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_1366314752908978208.tmp, p, --forced-package-id, 127, --min-sdk-version, 15, --target-sdk-version, 23, --version-code, 45904150, --version-name, 106.0.0.26.68, -F, /tmp/APKTOOL1488854893565011040.tmp, -0, arsc, -0, FBSIG, -0, assets/ComponentScriptBundle.js.meta, -0, assets/InboxV2Query_MessengerInboxUnits_Nodes.fbs.md5, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui-1.dex.jar.xzs.tmp~.meta, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui.dex.jar.xzs, -0, js, -0, assets/js-modules/UNBUNDLE, -0, xzs, -0, assets/secondary-program-dex-jars/secondary-2.dex.jar.xzs.tmp~.meta, -0, assets/secondary-program-dex-jars/secondary.dex.jar.xzs, -0, arsc, -I, /home/steve/.local/share/apktool/framework/1.apk, -S, /tmp/fb/res, -M, /tmp/fb/AndroidManifest.xml]
    at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:439)
    at brut.androlib.Androlib.buildResourcesFull(Androlib.java:464)
    ... 5 more
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_1366314752908978208.tmp, p, --forced-package-id, 127, --min-sdk-version, 15, --target-sdk-version, 23, --version-code, 45904150, --version-name, 106.0.0.26.68, -F, /tmp/APKTOOL1488854893565011040.tmp, -0, arsc, -0, FBSIG, -0, assets/ComponentScriptBundle.js.meta, -0, assets/InboxV2Query_MessengerInboxUnits_Nodes.fbs.md5, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui-1.dex.jar.xzs.tmp~.meta, -0, assets/java.com.facebook.katana.activity.codegenerator.ui/java.com.facebook.katana.activity.codegenerator.ui.dex.jar.xzs, -0, js, -0, assets/js-modules/UNBUNDLE, -0, xzs, -0, assets/secondary-program-dex-jars/secondary-2.dex.jar.xzs.tmp~.meta, -0, assets/secondary-program-dex-jars/secondary.dex.jar.xzs, -0, arsc, -I, /home/steve/.local/share/apktool/framework/1.apk, -S, /tmp/fb/res, -M, /tmp/fb/AndroidManifest.xml]
    at brut.util.OS.exec(OS.java:95)
    at brut.androlib.res.AndrolibResources.aaptPackage(AndrolibResources.java:433)
    ... 6 more
evilwombat commented 7 years ago

This seems to be the one (and only) offending line. I tried adding formatted="false" (as suggested by the error message) but this seems to have had no effect.

<item quantity="other">%1$s, %2$s, and %d other friends like this page.</item>

iBotPeaches commented 7 years ago

Wow Facebook is a huge application. I need to work on optimizing apktool with an application of that size.

So you found the affected line, which is a duplicate of #1360 . We have a new structure of strings that our positional substitutions isn't detecting. I'll work on patching that in #1360 , but in the meantime you can adapt that line to

<item quantity="other">%1$s, %2$s, and %3$d other friends like this page.</item>

We basically are just casting the 3rd variable to be positional.

evilwombat commented 7 years ago

Thanks dude!! I'll give it a try tomorrow. Facebook is indeed enormous, but the really interesting stuff is in /assets/. There's an xz file, consisting of 12 jar files concatenated together, each containing a dex file (each one being around 8MB in size). This is where the real application logic lives. I remember reading somewhere about how they had to split it up this way, to avoid DVM limits on some phones.

Either way, unpacking and patching this mess involves some work. Due to how this stuff is loaded, small/baksmali don't produced output that the custom Facebook loader is happy with. I don't know why - I'm just about embedded guy. But it's possible to decompile the Dex, sort of find the logic you want, disassemble the dex, match the logic to the opcodes, then use a hex editor to patch the opcodes you want (in-place), fix up the checksum, and put it all back together. It works for simple patches, but is time-consuming. If you're interested, I can post my fugly Python script for unpacking the mess, and my equally fugly shell script for putting the xz file back together. Though you can likely it out based on the info alone, if you feel like diving into something mildly disturbing :)

evilwombat commented 7 years ago

That did the trick. Thanks.