remove jre7 code

[iBotPeaches]

Original issue 527 created by connor.tumbleson on 2013-10-14T02:11:18.000Z:

Drop us back to JRE6 compatible. Rewrite any Java7 code.

[iBotPeaches]

Comment #1 originally posted by pangqingyuan1991 on 2013-10-14T14:05:23.000Z:

where can I download 2.0 compiled version?

[iBotPeaches]

Comment #2 originally posted by connor.tumbleson on 2013-11-12T12:49:22.000Z:

Issue 547 has been merged into this issue.

[iBotPeaches]

Comment #3 originally posted by connor.tumbleson on 2013-12-03T00:09:14.000Z:

Issue 559 has been merged into this issue.

[iBotPeaches]

Comment #4 originally posted by funorpain on 2013-12-05T08:12:08.000Z:

Applying following patch file fixes the problem.

diff --git a/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java b/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java index b969824..5460bae 100644 --- a/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java +++ b/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java @@ -585,7 +585,7 @@ public class Androlib {

         // in order to get the path relative to the zip, we strip off the absolute path, minus what we
         // already have in the zip. thus /var/files/apktool/apk/unknown/folder/file => /folder/file

• Path dest = fs.getPath(root.toString() + insert.getAbsolutePath().replace(location.toString(),""));

•      Path dest = fs.getPath(root.toString(), insert.getAbsolutePath().replace(location.toString(),""));
     Path newFile = Paths.get(insert.getAbsolutePath());
     Files.copy(newFile,dest, StandardCopyOption.REPLACE_EXISTING);
     fs.close();

  @@ -598,7 +598,7 @@ public class Androlib { try(FileSystem fs = FileSystems.newFileSystem(apkFileSystem, zip_properties)) {

     Path root = fs.getPath("/");

• Path dest = fs.getPath(root.toString() + insert.getAbsolutePath().replace(location.toString(),""));

•      Path dest = fs.getPath(root.toString(), insert.getAbsolutePath().replace(location.toString(),""));
     Path parent = dest.normalize();
  
     // check for folder existing in apkFileSystem

[iBotPeaches]

Comment #5 originally posted by connor.tumbleson on 2013-12-05T13:30:33.000Z:

Thanks for that fix, I'll test it tonight on Windows (which is where I was experiencing the problems)

[iBotPeaches]

Comment #6 originally posted by afernan4e on 2013-12-07T03:13:24.000Z:

Confirmed working under same conditions as Issue 559. Thanks for the patch!

[iBotPeaches]

Comment #7 originally posted by connor.tumbleson on 2014-01-04T12:06:11.000Z:

Issue 582 has been merged into this issue.

[iBotPeaches]

Comment #8 originally posted by connor.tumbleson on 2014-01-06T18:08:57.000Z:

Issue 583 has been merged into this issue.

[iBotPeaches]

Comment #9 originally posted by connor.tumbleson on 2014-01-09T14:02:51.000Z:

Issue 587 has been merged into this issue.

[iBotPeaches]

Comment #10 originally posted by abdulla.mahfood on 2014-01-09T16:23:07.000Z:

and hw to apply this patch?

[iBotPeaches]

Comment #11 originally posted by connor.tumbleson on 2014-01-09T16:40:12.000Z:

Issue 587 has been merged into this issue.

[iBotPeaches]

Comment #12 originally posted by connor.tumbleson on 2014-01-10T16:35:46.000Z:

On second thought. I like Java7.

Release Dates Java SE 6 (December 11, 2006) Java SE 7 (July 28, 2011) Hell, Java 8 betas are even out now.

Rewriting 3 major functions (Unknown Files, SmaliDebugging, Unit-Tests) into JRE6 will take a lot of time even further delaying the release of Apktool2.

Yes, there are errors like the above one, but that was due to me learning Jave NIO2 as I was programming it. It could use a JRE7 small rewrite to fix up the problems.

Then we should embrace JAVA7, if we choose to stay with it. Rewrite to use everything and anything that helps make our codebase more consistent.

try-with-resources, diamond operators, multi-catches, etc. I'll sleep on it, but really favoring Java7.

[iBotPeaches]

Comment #13 originally posted by achen.code on 2014-02-19T21:29:31.000Z:

In case this is still under debate, I vote that you stay on Java 7. Oracle stopped releasing Java 6 updates in February 2013.

[iBotPeaches]

Comment #14 originally posted by mforce2 on 2014-03-12T16:04:21.000Z:

I vote for Java7 as well, I see no reason to use Java6 as it's really old and Java8 will be out soon.

[iBotPeaches]

Comment #15 originally posted by connor.tumbleson on 2014-03-26T23:47:42.000Z:

We are sticking with Java7. If you want to use Apktool on Android, you can do the needed developing yourself to strip the 1.7 stuff and remove other dependencies.

(We will still move SnakeYAML to an Android compatible version in time, to ease the process)

Java8 is out. Java7 has been for 2.5 years. Java6 is old.