iCHEF / transcharts

Chart library built with React

https://ichef.github.io/transcharts/

Apache License 2.0

2 stars 0 forks source link

Turn off type checker on docz if it is in production #30

Closed chenesan closed 5 years ago

chenesan commented 5 years ago

Purpose

Sometimes the type check github action fails during building doc when executing yarn (which trigger yarn prepublish) (like https://github.com/iCHEF/transcharts/pull/29/checks?check_run_id=79929395) and this PR try to turn off type checking when it's in production build so the type-check github action will always work.

Changes

Turn off ForkTSCheckerWebpackPlugin when dev is false.

Risks

None.

TODOs

None.

chenesan commented 5 years ago

The check succeeded in https://github.com/iCHEF/transcharts/pull/30/checks?check_run_id=80468729 . I'm not 100% sure it's fixed since the failure happened randomly, but I guess this PR helps. If the checking is stable after merging this I would suggest force the check before merging PR :)