search

iCepa / Tor.framework

Tor framework for the iCepa project
Other
245 stars 53 forks source link

Fix various build issues with newer tors #61

Closed nmathewson closed 4 years ago

nmathewson commented 4 years ago

It looks like the current build scripts are doing strange things for Tor's include paths. Tor has a file called "src/lib/dispatch/dispatch.h", which will conflict with apple's dispatch/dispatch.h when you put src/lib in your include path. I'd recommend not doing that; I think it causes the error messages you were seeing in #53

This branch also stops using or.h in your .m files -- it isn't needed there any more, and was never a public API. It adds a note about log.h, which also isn't a public API, and will probably cause trouble down the line.

This branch does not solve the issues of building completely -- you'll need to edit the list of libraries in tor.sh a bit. I've added a comment about a better way to get that list.

tladesignz commented 4 years ago

Oh, man, thank you so much @nmathewson!

It's such a huge difference if someone with a real understanding of the C ecosystem looks at stuff like this. Compared to that I'm just a kid on a Bobby Car on a walled playground provided by Apple.

We're not worthy GIF

nmathewson commented 4 years ago

Hey, not to worry -- I only figured this out because I've seen this kind of thing happen a few times before. Long ago, it was when we had a file called "log.h" and solaris (anybody remember solaris?) also had a file called log.h. Next time something like this comes up, you'll know one more thing to look for.