iCepa / Tor.framework

Tor framework for the iCepa project
Other
249 stars 55 forks source link

Tor resignation not working with 0.4.2.7 #62

Closed Fonta1n3 closed 4 years ago

Fonta1n3 commented 4 years ago

I am using a similar method to OnionBrowser as per #56 for resigning the tor thread which had been working fine, yet with the latest update the tor thread stays intact and does not exit at all. Any ideas why that may be? Are you able to replicate that issue?

SwenVanZanten commented 4 years ago

Can confirm the problem. Looks like TorController.disconnect() isn't working anymore.

tladesignz commented 4 years ago

Hey! Thanks a ton for catching this! I'm in discussion with Tor folks: https://trac.torproject.org/projects/tor/ticket/33837#comment:18

We'll see what happens. For now: Stay with 0.4.0.6!

tladesignz commented 4 years ago

Moved bug to https://trac.torproject.org/projects/tor/ticket/33924.

tladesignz commented 4 years ago

I got one step further, however now there's a new issue: After restart, testing with Onion Browser, OB explodes with all sorts of EXC_BAD_ACCESS crashes, even when just trying to print a debug message. Will work with Tor folks on it.

tladesignz commented 4 years ago

Ok, finally resolved. I just released a new v403.5.1 containing Tor 0.4.3.5 which fixes all problems. Enjoy!

SwenVanZanten commented 4 years ago

Awesome! Thank you for letting know 💪