search

iCepa / Tor.framework

Tor framework for the iCepa project
Other
249 stars 55 forks source link

Request to add via SwiftUI package manager #78

Open BenGWeeks opened 1 year ago

BenGWeeks commented 1 year ago

Ability to simply add via the swift package manager would be awesome.

Anyone able to give some advice on steps to manually add this framework into a SwiftUI project (actually a Nostr client, Damus).

Fonta1n3 commented 1 year ago

I can definitely help with that! Not the package itself but getting it running on Damus.

BenGWeeks commented 1 year ago

That would be awesome thanks @Fonta1n3.

This is the progress so far:

https://github.com/BenGWeeks/damus/tree/tor-support

Let me know if you you would like contribute access!

Will be submitting this as a PR.

Fonta1n3 commented 1 year ago

That would be awesome thanks @Fonta1n3.

This is the progress so far:

https://github.com/BenGWeeks/damus/tree/tor-support

Let me know if you you would like contribute access!

Will be submitting this as a PR.

Hey for sure, I would love to contribute. No guarantees but I will try.

BenGWeeks commented 1 year ago

Invited!

tladesignz commented 1 year ago

Interesting. Are you going to create a PR? Let me know how this goes. I always thought SPM is only for Swift stuff, but that ssems to be uninformed/outdated?

BenGWeeks commented 1 year ago

Interesting. Are you going to create a PR? Let me know how this goes. I always thought SPM is only for Swift stuff, but that ssems to be uninformed/outdated?

I've only started SwiftUI development since December or so my knowledge is limited.

Yes, the iCepa/Tor.framework project can be made compatible with Swift Package Manager, even if it is not a pure Swift project. Swift Package Manager can handle projects with mixed-language sources, such as Objective-C and Swift, as long as the appropriate configurations are in place.

Yes, I think I may have a go at submitted a PR to add Swift Package Manager to this repo if desirable. I assume others would find it useful.

BenGWeeks commented 1 year ago

Related: https://github.com/daltoniam/Starscream/issues/971

BenGWeeks commented 1 year ago

It looks like creating the Swift Packager Manager would probably require more knowledgeable people of the framework due to package dependencies. Any plans to implement this? Would make it a lot easier to integrate into XCode projects I believe.

tladesignz commented 1 year ago

Package dependencies? The only dependencies here are Tor itself, which is written in C. (Along with some dependencies it has: libevent, OpenSSL, xz and some system-provided libraries.)

Does SPM support Git submodules and calling shell build scripts? If not, this is doomed to fail.