search

iCepa / Tor.framework

Tor framework for the iCepa project
Other
245 stars 53 forks source link

Fix submodule clone error and update submodules #92

Closed fel1x-developer closed 1 month ago

fel1x-developer commented 1 month ago

XZ Utils moved its git repo to https://github.com/tukaani-project/xz.git after its backdoor incident. Although macOS is not affected by the backdoor, it is encouraged to keep XZ Utils and other components up-to-date.

This PR includes disabling "-fembed-bitcode-marker". Bitcode has been depreceated since Xcode 14, and I don't think this would cause any breaking changes.

trakov commented 1 month ago

Hi @fel1x-developer , Did you try to use the updated XZ Utils from the new repo? Does it work for you? I tried it and it's downloaded well. I added Tor.framework via CocoaPods (I tried my branch as well as your branch), and faced the following issue:

Screenshot 2024-07-25 at 13 19 29

fel1x-developer commented 1 month ago

@trakov It might require

$ pod cache clean
$ pod update
$ pod install

Then clean build folder (Shift + Cmd + K) and try again.

If it still fails, delete and re-clone the code.

fel1x-developer commented 1 month ago

And do not forget git submodule update --init --recursive

tladesignz commented 1 month ago

XZ Utils moved its git repo to https://github.com/tukaani-project/xz.git after its backdoor incident.

Ah, great. Thanks for that hint!

Although macOS is not affected by the backdoor, it is encouraged to keep XZ Utils and other components up-to-date.

To be clear: Tor.framework was never affected by the backdoor, because it never used the backdoored versions.

This PR includes disabling "-fembed-bitcode-marker". Bitcode has been depreceated since Xcode 14, and I don't think this would cause any breaking changes.

Wat? Sorry, but I never heard of anything like "bitcode is deprecated". AFAIK, it's quite the opposite. Apple very much likes bitcode and enforces that on some platforms (watchOS and tvOS, famously).

Besides that, your change doesn't remove bitcode stuff, just the "bitcode marker" stuff. And I don't see a reason, why that should go.

Anyway, even if that wouldn't be a thing, I'm sorry, I cannot accept your PR. Since your changes affect core things here, and this is security-relevant code, I cannot take the risk of pulling such a PR and accidentally take in a security problem.

But thank you very much for prodding me about the recent changes to Tor and xz! I'll reproduce, what you suggest and will soon release a new version.