search

iChun / BetterThanLlamas

Dapper Llamas.
GNU Lesser General Public License v3.0
3 stars 2 forks source link

fix: crash from specifying a null level for the rabbit instance #4

Closed Thatsmusic99 closed 1 year ago

Thatsmusic99 commented 1 year ago

Covers issues #2 and #3 for 1.18 versions of the game.

GaeaKat commented 1 year ago

Doesn't this move the crash until later in the game, when rabbitInstance is attempted to be used?

here - https://github.com/iChun/BetterThanLlamas/blob/985611f4097d4d325f3853594d86104049ee2e45/src/main/java/me/ichun/mods/betterthanllamas/client/render/LlamaFancyLayer.java#L219

Thatsmusic99 commented 1 year ago

Nope, see lines 187-189. The variable is re-assigned there.

It's pretty much a backport of the fix used in 1.19.

iChun commented 1 year ago

Thanks! My apologies for the crashes people experienced on that day. Didn't realise the bug was only fixed on 1.19+