iChun / Morph

My entry for ModJam #2.
GNU Lesser General Public License v3.0
152 stars 183 forks source link

Mob Models Misshapen after Morph 0.7.1 #496

Closed Techition closed 6 years ago

Techition commented 10 years ago

So many M's, anyways! I am using Morph Beta 0.7.1 and I have noticed that many of the mob models will end up with their polygons in a twist. This also occurs at times with the player model (An occurrence I have nicknamed "Legs") where the arms, head and torso all use the same texture as the legs of the avatar skin. I have seen everything from repeated textures, polygonal chaos and invisible mobs after morphing into them.

This first happened in a heavily modded world. I thought "Maybe the mods are conflicting." so I started up a new world with only the morph mod installed and, while it took a bit longer to happen, sure enough, I morphed into a cat at one point and ended up as just a floating tail. As funny as this may be (Trust me, I've had a few good laughs about this) it can become an issue when hostile mobs end up invisible due to it since it doesn't affect just the model in use by the player but all models of that type. Morphing into something else sadly doesn't fix the messed up models, they remain disfigured and morphing more just worsens it. If it just effected the player it would be tolerable because the functionality would still be there but, since it effects all mobs using that model, well, being attacked by a horde of invisible zombies/spiders/etc is a bit less tolerable.

When this occurred I had not messed with the config file or the coding of the mod itself. It was tested in both heavily modded and exclusively morph modded environments. It is less likely to occur on the first few morphs however morphing back and forth makes the issue show up. It has occurred both in single player and multiplayer for me. When in multiplayer even the other people morphing will cause this issue on my end.

Technical Info: Forge version: 9.11.1.965 Morph Version: Beta 0.7.1

So far I've not found anyone else having this issue so I'm really trying to figure out what's causing it and how to fix it. When it came to install I just dropped the morph mod zip folder right in the mod folder the way you normally install mods so this has me a bit stumped.

iChun commented 10 years ago

Screenshots would help... You have optifine installed?

Techition commented 10 years ago

I normally have optifine installed, yes, but when I did a morph-only test I removed optifine as well and still got the same malformation of the models thing going on. this is a wolf I present to you the world's oddest looking wolf!

And then, there's what I call "Legs" meet legs

So as you can see, very humorous results but most certainly a case of drunken polygons going on here.

sebi2306 commented 10 years ago

Your specifications would be nice to have, as people use Optifine mostly because they have an old GPU that has 10-20 FPS on its own (happens to me)

iChun commented 10 years ago

Would it be similar issues as in the screenshots in this issue? https://github.com/iChun/Morph/issues/473

Also does it happen when the mod is installed standalone?

Techition commented 10 years ago

Yes, as I said previously, it does occur when morph is the only mod installed. No optifine, no shaders, no NEI/TMI, anything. I first noticed it in a modded world but the screenshots I included are from a completely unmodded (Besides Morph!) world.

There are similarities to the screenshots in the issue you posted though the ones I get tend to be repeating polygons across the whole model but, yes, it is somewhat similar.

I mean, I could go through the code myself and try to see if I can see the issue but, out of respect for you, the mod maker, I have avoided tearing up the code to see if I can find and fix it myself. If you're alright with me decompiling and altering the code copy/mod copy I have on my machine I could try to run a bit of testing and see if I can isolate the problem code and find a fix, but I didn't wanna do that without your go ahead, again, out of respect for you as a fellow programmer.

But yes, the issue is like the one you linked, there are variances but it is similar.

iChun commented 10 years ago

You're fine with going through the code and trying to fix it yourself, the mod is open source after all.

I'm not sure what'll be causing this even though I don't do anything with manipulating the models (i make a close copy of the original model, and then I copy those when I do any animation), so I'm pretty much at loss, as I'm not experiencing this issue on my system. I do recommend you update your java and your graphics drivers if they are not already up to date, though.

Unfortunately do note that the repository is currently for Minecraft 1.7, as the port is still being worked on. You can mess around with the legacy branch if you wish to stay on 1.6.4 but it's be best if you poked on the 1.7 instance.

Techition commented 10 years ago

I did not know it was open source >_> welp, that'll make trouble shooting a bit easier.

My java and graphic drivers are updated and streamlined for my system's setup, but I will be sure to cross reference a bit and see if there's a conflict there as well, since it seems I'm not alone in this issue.

I could report any fixes/findings to you if you would like, since someone else is having this issue couldn't be a bad idea to see about helping anyone else who is meeting with this malformation out in the process of fixing my own problems. Now to see if those ten years in my chosen field pay off when it comes to isolating this lil bugger of a problem.

iChun commented 10 years ago

Well, you ARE posting on the repository for the mod XD FYI ModJam mods are required to be open source (you can close the source afterwards but I didn't see any point)

I've been working on issues and stuffs with the mod for the past 12 hours or so so I'm pretty wiped out, won't be touching it for much more until I get some sleep. Hope you get some luck with the issue.

Techition commented 10 years ago

Ah, this thread is my first time on github even so I didn't know. Whoops. . .well, sometimes ya feel like a nut!. . . .ANYWAYS, go get some sleep you! Won't do ya any good if you end up with QWERTY imprinted in your forehead!

And alrighty, I'll take a crack at it, once I get some sleep myself because I'm kinda like the pot calling the kettle black here at the moment.

Joannou1 commented 10 years ago

Hey, I just thought I would pop in and add my 0.02.

Here are some screenshots of the chaos..

b7bdd

5805a

At one point my hand turned into my head after I morphed back.

c95e4

Computer: CPU: i7 2600k MEM: 16GB RAM (6GB For MC) GPU: R9 280x

Latest drivers for graphics and newest vesion of x64 Java.

Using 0.7.1

iChun commented 10 years ago

Wait so even your hand changed?

iChun commented 10 years ago

I have inkling suspicion. I'll need to speak to one of you folks on IRC to look into this further, if possible.

Joannou1 commented 10 years ago

Sounds good, it did change my hand in first person and third person.. All sorts of weird stuff happens with players/NPC's.

iChun commented 10 years ago

I have a feeling it's an OpenGL issue though guys, what versions of OGL are you guys using?

iChun commented 10 years ago

Bump.

Techition commented 10 years ago

My apologies for not responding in a while. My health has tanked so sadly I haven't been able to spend much time trying to troubleshoot the issue on my end. I do have a suspicion though, but I'll have to wait until I feel well enough to sit at my main computer for more than a few minutes to test my theory.

I'm thinking the issues on my end may be due to my own modifications to how my system runs, I have things data throttled, priority setups for processor resources and all that which may be affecting how the mod runs so I need to rule those out before I can properly troubleshoot it on my setup.

Again I apologize for not responding previously but, when my health tanks, I'm two beats away from a zombie when it comes to mental ability and energy.

DevilDriver572 commented 10 years ago

I'm not using OpenGL and still getting similar problems. I do have OpenAL and don't believe it should cause the problem.

iChun commented 10 years ago

If your minecraft screen even shows, you're using opengl On 19 Jul 2014 22:39, "DevilDriver572" notifications@github.com wrote:

I'm not using OpenGL and still getting similar problems. I do have OpenAL and don't believe it should cause the problem.

— Reply to this email directly or view it on GitHub https://github.com/iChun/Morph/issues/496#issuecomment-49511226.

DevilDriver572 commented 10 years ago

I had no clue. Well I did a few tests and suspect seems to mostly be teleportation. Is there a way to see about that?

iChun commented 10 years ago

Can you properly reproduce your issue?

DevilDriver572 commented 10 years ago

Sorry. I somehow fixed the issue. Might've been due to one of the mods being in the server's mods folder when it wasn't needed. On Aug 4, 2014 3:39 PM, "iChun" notifications@github.com wrote:

Can you properly reproduce your issue?

— Reply to this email directly or view it on GitHub https://github.com/iChun/Morph/issues/496#issuecomment-51107024.

Joannou1 commented 10 years ago

Hey, it's been awhile since I posted here...

But I decided to create my own modpack, and out of curiosity I removed Morph to see if it would help with the model issues... Which it did not.

Rather odd, since it did before.

I know at this point it's no longer an issue for Morph, but I still want to figure out what is causing this bizarre issue.

I've noticed a trend, I have an R9 280x and my friend has an R9 270x. Both of us get the same issue.

We're getting more people to test soon, so I'll post those results as well. Here's some more pictures of the issue, models from many different mods.

"Zepplin" a1eb32e170d9920fe68e24e21932efc3

Trains from Traincraft.. Some are fine, others are not.. Random occurance. a1eb32e170d9920fe68e24e21932efc3

What's apparently a Crocodile... a1eb32e170d9920fe68e24e21932efc3

Other things... a1eb32e170d9920fe68e24e21932efc3

a1eb32e170d9920fe68e24e21932efc3

a1eb32e170d9920fe68e24e21932efc3

iChun commented 6 years ago

This issue is being closed as a purge of issues due to the Morph rewrite to 1.12.2 finally being released. Support for the 1.7.10 version has long been dropped and focus has shifted to the 1.12.2 version of the mod instead.