search

iChun / Sync

My entry for ModJam #3
GNU Lesser General Public License v3.0
58 stars 41 forks source link

Dupe bug with baubles #195

Closed lag42 closed 6 years ago

lag42 commented 6 years ago

Baubles remain in the inventory after changing shells as well as saving to the shell they were in

iChun commented 6 years ago

Dang it this issue again? Cc @Kihira

On 7 Oct 2017 12:56 am, "lag42" notifications@github.com wrote:

Baubles remain in the inventory after changing shells as well as saving to the shell they were in

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iChun/Sync/issues/195, or mute the thread https://github.com/notifications/unsubscribe-auth/ACMSTKW-pBd_g8hFyQx2KE2-NlTLb4Orks5splvUgaJpZM4Pwwum .

kihira commented 6 years ago

Ah yes, this issue. I think it was due to baubles saving in a non standard location which we wasn't saving. I think we added code to work around it but it may have changed since.

On Sat, 7 Oct 2017, 01:16 iChun, notifications@github.com wrote:

Dang it this issue again? Cc @Kihira

On 7 Oct 2017 12:56 am, "lag42" notifications@github.com wrote:

Baubles remain in the inventory after changing shells as well as saving to the shell they were in

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iChun/Sync/issues/195, or mute the thread < https://github.com/notifications/unsubscribe-auth/ACMSTKW-pBd_g8hFyQx2KE2-NlTLb4Orks5splvUgaJpZM4Pwwum

.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/iChun/Sync/issues/195#issuecomment-334891181, or mute the thread https://github.com/notifications/unsubscribe-auth/ABav-VB3LaYTDfvIUrO7OV4ehxW2HUnrks5sprTPgaJpZM4Pwwum .

ichttt commented 6 years ago

Are you sure this is still an issue in 1.12? I am unable to reproduce this with latest baubles on 1.12...

ichttt commented 6 years ago

Yeah, it was an issue again. Baubles saved the items as a capability, and sync copies these over to the new shell but it also keeps them in the old shell. I fixed it in 7d2b90c6f640cc21b9ac8890548e143d2c573e54