search

iChun / Sync

My entry for ModJam #3
GNU Lesser General Public License v3.0
60 stars 42 forks source link

Baubles and CAR item dupes #208

Open GreatestFool opened 6 years ago

GreatestFool commented 6 years ago

When transferring to a new shell, all baubles, and cosmetic armor worn using the mod cosmetic armor reworked. Soul bound items like my sword were also duplicated. Have checked to make sure, but Levels 2 (Now renamed to Weapon Levels) is not present. Currently using Sync 7.0.2.

daAresinger commented 6 years ago

I won't make a separate issue, unless told to do otherwise: For me the entire Inventory is duped every time I switch Shells. When I then switch I take my current inventory with me without deleting it on the shell I am leaving.

I do not have Weapon Levels installed, nor Cosmetic Armor. However I do have Baubles and Tinkers Construct. (aswell as countless other mods, but these two have come up in this problem before).

This is a video threw together before I knew this was a known issue: https://youtu.be/eTm3gCt5tXw

If you are interested I can export the Minecraft instance and upload it somewhere (MultiMC Instance)

ichttt commented 6 years ago

Both of you please try https://github.com/iChun/Sync/files/1890896/Sync-1.12.2-7.0.3BETA.zip and see if it fixes the issue

daAresinger commented 6 years ago

It fixed the duping. My inventory (Including Baubles) is now persistent between all shells. Is this intended?

ichttt commented 6 years ago

Nope, not intended. Please provide a modlist so I can track the issue.

daAresinger commented 6 years ago

It may be easier to download my modfolder: Dropbox

[12:00:44] [Netty Server IO #1/INFO] [FML]: Client attempting to join with 63 mods : astralsorcery@1.8.9 dynamictreesbop@1.0.0 animania@1.4.7 mobdismemberment@7.0.0 jei@4.9.1.172 nei@2.4.1,ivtoolkit@1.3.3-1.12 craftstudioapi@1.0.0 thaumicjei@1.2.1 mcp@9.42 I couldn't find a link to mcp 9.42 clumps@2.0.0 diethopper@1.1 controlling@3.0.6 journeymap@1.12.2-5.5.2 chameleon@1.12-4.1.3 microblockcbe@2.4.0.55 not sure if this is right inventorytweaks@1.64-dev+release.110.b4fac73 stg@1.11.2-1.1.2 geneticsreborn@1.09 sync@7.0.3BETA XD waila@1.8.25 ichunutil@7.1.4 guideapi@1.12-2.1.5-60 enderstorage@2.4.2.126 thaumcraft@6.1.BETA10 immersivepetroleum@1.1.9 forge@14.23.3.2655 bettercompass@1.3.0 bloodmagic@1.12.2-2.2.11-96 morph@7.1.2 minecraft@1.12.2 well... tconstruct@1.12.2-2.9.1.65 portalgun@7.0.2 funkylocomotion@1.0 openglider@@VERSION@ immersiveengineering@0.12-81 biomesoplenty@7.0.1.2387 baubles@1.5.2 reccomplex@1.4.7 chickenchunks@2.4.1.71 extrautils2@1.0 roguelike@1.8.0 mantle@1.12-1.3.2.24 storagedrawers@1.12-5.3.5 elevatorid@1.3.6 FML@8.0.99.99 dimdoors@3.0.8+271 tombstone@2.9.1 norecipebook@1.1.09 minecolonies@1.12.2-0.8.8147 appleskin@1.0.9 embers@0.230 minecraftmultipartcbe@2.4.0.55 forgemultipartcbe@2.4.0.55 flatcoloredblocks@mc1.12-6.6 tinkersjei@1.0 codechickenlib@3.1.7.340 fastleafdecay@v14 chiselsandbits@14.16 dynamictrees@1.12.2-0.7.6 movillages@1.5.4 mobends@0.24 base@3.7.1

ichttt commented 6 years ago

Here is another testing build with a config option to disable the new item sync mechanism if it breaks with some of your mods. Search for "Try tranfering persistent items" and set it to no in the config gui (or 0 if you edit the file), and please report back if everything is as you exspected. Just unzip the zip file and replace the original sync jar with this one. Sync-1.12.2-7.0.3BETA2.zip

GreatestFool commented 6 years ago

Have tested it with "Try transferring persistent items" on and off, neither fixes the issue for me. Baubles and Cosmetic Armor Reworked items stay within their slots, though it seems that when "Try transferring persistent items" was set to 'yes' the items did not duplicate but rather moved over to a new shell instead of staying with the shell they were in originally.

Mod list.

daAresinger commented 6 years ago

sorry, I couldn't check any sooner. It works fine for my normal inventory when I turn the option off. But baubles is still persistent.