search

iChun / iChunUtil

iChunUtil as required by several of my mods.
GNU Lesser General Public License v3.0
40 stars 53 forks source link

iChunUtil Render Bug #102

Closed dodgycoffee closed 8 years ago

dodgycoffee commented 8 years ago

Hello there!

Hoping you can help with this one. So I'm using a custom private modpack and began experiencing a weird issue with the mod "Matter Overdrive". Specifically, rendering issues with phasers that also cause a variety of openGL errors for surrounding players. I reached out to the mod dev with the issue, and even gave him a copy of my pack to take a look. From his research he determined that it was an issue with iChunUtil rendering.

"It seem that iChunUtil is causing the error. They forgot to check if an item's icon is null."

He said it might be in relation to iChunUtil and using backtools. When backtools is removed, he found no problem. He also gave me a copy of the log specifically where it shows the issue for reference.

http://pastebin.com/J6h9ec0L

I'm using iChunUtil 4.2.2 (latest for 1.7.10). I know it is not the most current version overall, and the issue may very well be fixed in the newer version. However since majority of the mods I need are 1.7.10, that is where I am stuck. Is it possible to get a fix for this issue?

Distjubo commented 8 years ago

Does it only happen with Matter Overdrive?

dodgycoffee commented 8 years ago

I've only noticed the problem when with Matter Overdrive phasers/phaser rifles, but is triggered by iChunUtil/BackTools combination as shown in the log. When back tools is removed issue is not present.

shadowfacts commented 8 years ago

This bug appears to be caused because there is no verification that an item's icon is not null. This bug was found using Matter Overdrive (the Phaser and Phaser Rifle don't have icons) but would theoretically also be a problem with any other item that used a custom item renderer instead of an icon.

iChun commented 8 years ago

By Minecraft code convention, no items should ever have a null IIcon, which is why I never checked to see if it is null.

On Thu, Sep 17, 2015 at 3:07 PM, Axl Sjolund notifications@github.com wrote:

I've only noticed the problem when with Matter Overdrive phasers/phaser rifles, but is triggered by iChunUtil/BackTools combination as shown in the log. When back tools is removed issue is not present.

— Reply to this email directly or view it on GitHub https://github.com/iChun/iChunUtil/issues/102#issuecomment-141097744.

iChun commented 8 years ago

This, IIRC, changes in 1.8, however, so the check is (or, should be) present in the 1.8 versions.

On Thu, Sep 17, 2015 at 4:54 PM, Kay Vin Tee ohai.ichun@gmail.com wrote:

By Minecraft code convention, no items should ever have a null IIcon, which is why I never checked to see if it is null.

On Thu, Sep 17, 2015 at 3:07 PM, Axl Sjolund notifications@github.com wrote:

I've only noticed the problem when with Matter Overdrive phasers/phaser rifles, but is triggered by iChunUtil/BackTools combination as shown in the log. When back tools is removed issue is not present.

— Reply to this email directly or view it on GitHub https://github.com/iChun/iChunUtil/issues/102#issuecomment-141097744.

dodgycoffee commented 8 years ago

Ok so it should be corrected in the 1.8 versions. But as I am still stuck with 1.7 because of mod support, is there a possibility for a hotfix for the 1.7 version?

I prefer to use the backtools mod if I can get a fix, but if not I can just remove it I suppose.

iChun commented 8 years ago

Most unlikely, sorry, again, this isn't something that is for me to fix.

On Thu, Sep 17, 2015 at 5:12 PM, Axl Sjolund notifications@github.com wrote:

Ok so it should be corrected in the 1.8 versions. But as I am still stuck with 1.7 because of mod support, is there a possibility for a hotfix for the 1.7 version?

I prefer to use the backtools mod if I can get a fix, but if not I can just remove it I suppose.

— Reply to this email directly or view it on GitHub https://github.com/iChun/iChunUtil/issues/102#issuecomment-141135981.