search

iChun / iChunUtil

iChunUtil as required by several of my mods.
GNU Lesser General Public License v3.0
40 stars 53 forks source link

BlockPickupEvent changes #133

Closed LatvianModder closed 7 years ago

LatvianModder commented 7 years ago

Made BlockPickupEvent Forge-styled with getters, added EntityPlayer, changed few Lists to Collections HashSet should be used for block positions rather than ArrayList, but now that there is a Collection, it doesn't matter anymore

iChun commented 7 years ago

What benefit does Collection have over List?

I only just realised the field is public and there isn't any getter. I guess I'm still living in the past where that was an okay thing to do for Forge events.

Blocks are meant to be picked up by more than just players, so EntityLivingBase is more preferred, really.

I need to revise this event, really. It's meant to be more a BlockToEntityEvent rather than a BlockPickupEvent. Will do so for my next update mid-Jan

iChun commented 7 years ago

Also I was hoping to put in the current item stack as well in a field if you're gonna include the player/entity