search

iChun / iChunUtil

iChunUtil as required by several of my mods.
GNU Lesser General Public License v3.0
40 stars 53 forks source link

[1.12.2] 'O' options hotkey #161

Closed Robijnvogel closed 6 years ago

Robijnvogel commented 6 years ago

I know this was the way you could get to the iChun mods options. Both in the PiP and iChunUtil configs it says to "Go to the options page and hit O to show other options."

In 1.12.2, this does not seem to work for me at the moment. I made sure that none of the controls in Minecraft's Vanilla Controls menu are mapped to "O", but I can't seem to open your options menu in this version of Minecraft. I tried hovering my mouse pointer over various regions of the Options menu, including but not limited to buttons.

I forced a crash for the ease of sharing my setup's information: https://pastebin.com/hbEYLFir

iChun commented 6 years ago

Are you using the default QWERTY keyboard layout? If you're not you should be able to click on the bottom right (on the text) to open the config GUI instead

On 23 Nov 2017 12:06 am, "Mathijs Riezebos" notifications@github.com wrote:

I know this was the way you could get to the iChun mods options. Both in the PiP and iChunUtil configs it says to "Go to the options page and hit O to show other options."

In 1.12.2, this does not seem to work for me at the moment. I made sure that none of the controls in Minecraft's Vanilla Controls menu are mapped to "O", but I can't seem to open your options menu in this version of Minecraft. I tried hovering my mouse pointer over various regions of the Options menu, including but not limited to buttons.

I forced a crash for the ease of sharing my setup's information: https://pastebin.com/hbEYLFir

-

Make it work again. If some other mod must be the cause, I'd like to test this for you. :)

[Suggestion] Register your hotkeys in Minecraft's Controls menu, like 99% of other mods do.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/161, or mute the thread https://github.com/notifications/unsubscribe-auth/ACMSTOlDemnuv4fIn0xw-OPoAPEn9NHcks5s5EZ2gaJpZM4QnozK .

iChun commented 6 years ago

I've said it before and I'll say it again. I'm using a different config GUI because my keybinds vary slightly from MC's. I added modifiers before they existed for MC and I also listen for when the key is released.

The last time I checked what forge had done I remember thinking that it still wasn't viable for my uses just yet.

I don't remember why now but I might reevaluate this in the future. I think it was because they don't accept multiple modifiers

On 23 Nov 2017 5:05 am, "Kay Vin Tee" ohai.ichun@gmail.com wrote:

Are you using the default QWERTY keyboard layout? If you're not you should be able to click on the bottom right (on the text) to open the config GUI instead

On 23 Nov 2017 12:06 am, "Mathijs Riezebos" notifications@github.com wrote:

I know this was the way you could get to the iChun mods options. Both in the PiP and iChunUtil configs it says to "Go to the options page and hit O to show other options."

In 1.12.2, this does not seem to work for me at the moment. I made sure that none of the controls in Minecraft's Vanilla Controls menu are mapped to "O", but I can't seem to open your options menu in this version of Minecraft. I tried hovering my mouse pointer over various regions of the Options menu, including but not limited to buttons.

I forced a crash for the ease of sharing my setup's information: https://pastebin.com/hbEYLFir

-

Make it work again. If some other mod must be the cause, I'd like to test this for you. :)

[Suggestion] Register your hotkeys in Minecraft's Controls menu, like 99% of other mods do.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/161, or mute the thread https://github.com/notifications/unsubscribe-auth/ACMSTOlDemnuv4fIn0xw-OPoAPEn9NHcks5s5EZ2gaJpZM4QnozK .

Robijnvogel commented 6 years ago

I am using the default QWERTY keyboard layout. (United States International)

What bottom right text do you mean. Oh, in the key binds menu. :o That is waaaaaay too well hidden.

But the O key still doesn't work.

iChun commented 6 years ago

Well you were looking for iChunUtil keybinds. Actually I think I removed the 'O' keybind because I've moved setting mod configs to the mods list.

On 23 Nov 2017 7:25 am, "Mathijs Riezebos" notifications@github.com wrote:

I am using the default QWERTY keyboard layout.

What bottom right text do you mean. Oh, in the key binds menu. :o That is waaaaaay too well hidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/161#issuecomment-346499693, or mute the thread https://github.com/notifications/unsubscribe-auth/ACMSTOxZgXGcNqMcx8tHzbY9v_Qlo67Iks5s5K19gaJpZM4QnozK .

iChun commented 6 years ago

I don't really remember anymore heh, it's been too long.

On 23 Nov 2017 7:25 am, "Mathijs Riezebos" notifications@github.com wrote:

I am using the default QWERTY keyboard layout.

What bottom right text do you mean. Oh, in the key binds menu. :o That is waaaaaay too well hidden.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/161#issuecomment-346499693, or mute the thread https://github.com/notifications/unsubscribe-auth/ACMSTOxZgXGcNqMcx8tHzbY9v_Qlo67Iks5s5K19gaJpZM4QnozK .

Robijnvogel commented 6 years ago

Edited the OP of this issue, for what I think would be the easiest temporary fix for now.

iChun commented 6 years ago

In my defence, I think I basically just forgot to update the localisation

iChun commented 6 years ago

https://github.com/iChun/iChunUtil/commit/b485c9e6b09682567821765df242a0f7d733b06a

I've checked and MC+Forge keybinds still do not support multiple modifiers so my keybinds will be here to stay until then.

Robijnvogel commented 6 years ago

If you haven't fixed anything, I think you should not close this issue. Unless you choose to not implement any of the three ideas I proposed.

But that is just my view on Github issues.

iChun commented 6 years ago

Issue resolved, issue closed.

Robijnvogel commented 6 years ago

"I've already updated the localisation which goes into the config to explain how to get to my own keybinds." You did not explicitly state this. I am glad you did. :D

Have a nice day!

iChun commented 6 years ago

I linked a commit which does so before I mentioned why I won't be using forge keybinds

On 19 Dec 2017 12:15 AM, "Mathijs Riezebos" notifications@github.com wrote:

"I've already updated the localisation which goes into the config to explain how to get to my own keybinds." You did not explicitly state this. I am glad you did. :D

Have a nice day!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/161#issuecomment-352429294, or mute the thread https://github.com/notifications/unsubscribe-auth/ACMSTNy7Wx39hWAIpCapKOB8d3gVb4K0ks5tBmxvgaJpZM4QnozK .

Robijnvogel commented 6 years ago

Sorry, I typically mention the issue in the commit, which puts it in the feed of the issue separately. Not the other way around. I'm really sorry for overlooking that commit link.

iChun commented 6 years ago

Yeah I forgot to mention it that's why I had to put a link, heh. I normally mention which issue as well.

On 19 Dec 2017 8:16 AM, "Mathijs Riezebos" notifications@github.com wrote:

Sorry, I typically mention the issue in the commit, which puts it in the feed of the issue separately. Not the other way around. I'm really sorry for overlooking that commit link.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/161#issuecomment-352567659, or mute the thread https://github.com/notifications/unsubscribe-auth/ACMSTEOXebRTCBFS5sUa1tN8_ybETrE0ks5tBt0bgaJpZM4QnozK .