Memory Leak on Renderer

iChun / iChunUtil

iChunUtil as required by several of my mods.

GNU Lesser General Public License v3.0

40 stars 53 forks source link

Memory Leak on Renderer #177

Closed notfood closed 5 years ago

notfood commented 5 years ago

There is a memory leak in the renderer whenever IChunUtil is installed.

Hit this issue with CustomNPC mod but it affects other mods as well. Grimoire of Gaia is another mod affected. The setup to reproduce is simple, just line the mods and wait. The more mobs, the more ram is leaked.

This issue happens under Windows and Linux, I couldn't test on Mac.

Enviroment used for test:

Linux 4.18.3 ArchLinux
Java 8.181

Minecraft 1.12.2
Forge 1.12.2-14.23.4.2756

iChunUtil 1.12.2-7.1.4
CustomNPCs 1.12.2 (09jul18)

Recorded for reference:

There is no ram ramp up here, no matter how long you wait.

With iChunUtil added:

There is a 20mb/s ramp up of ram usage here, eventually it runs out of memory and will crash to desktop. I speed it up so it's noticeable.

StephenBurgos commented 5 years ago

Same issue. iChunUtil-1.12.2-7.1.4 CustomNPCs 1.12.2(26aug18) No other mods installed.

Forge 14.23.5.2768 MC 1.12.2 Java 1.8.0_191

DemonfangArun commented 5 years ago

What precisely does it take to trigger this issue? I have had ichunutil and moreplayermodels installed in my pack for months and haven't experienced this memory issue (or at least not to the extent above). I've been able to play for hours on end with 8GB of ram allocated, and most of that is already in use from the get-go.

StephenBurgos commented 5 years ago

The issue is triggered by having iChunUtil and Custom NPCs. I haven't tried it with More Player Models. Then to start the leak, you simply spawn in an NPC.

talonos2 commented 5 years ago

Can confirm. It's somehow leaking outside of heap space, so you cannot protect yourself with -xmx command line parameters. I had 32 GB ram, and I went to lunch, and came back to find it had all filled up and spilled over into swap space.

iChun commented 5 years ago

Good news, I've spoken to Noppes and he's identified the issue on his end. It should be fixed in his mods from the next release.

Celophy commented 4 years ago

help, i have the same problem!!

StephenBurgos commented 4 years ago

If you read above you will see the comment by iChun that Noppes is fixing the problem. I’m not sure if that fix has been released yet or not.