iChun / iChunUtil

iChunUtil as required by several of my mods.
GNU Lesser General Public License v3.0
40 stars 53 forks source link

What about to add more configs? #188

Closed shoverno2 closed 4 years ago

shoverno2 commented 5 years ago

There so many non used processes, many of them makes bags or pollute RAM. Just why not?

iChun commented 5 years ago

That would be the plan for a major refactorisation of the mod planned for 1.13+. I would rather not change too much in 1.12 right now. I am however aware of the various issues going on with the mod and I'll see how they can be addressed in a future update, if there will be any new updates for 1.12.2.

On Wed, 5 Jun 2019, 2:43 PM shoverno2, notifications@github.com wrote:

There so many non used processes, many of them makes bags or pollute RAM. Just why not?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/188?email_source=notifications&email_token=AARRETDCRLAUBXJXVFKTINDPY5OAHA5CNFSM4HTQ4F22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXWEJKQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AARRETHMLMWHHWTZNXFI2ATPY5OAHANCNFSM4HTQ4F2Q .

shoverno2 commented 5 years ago

Well, does 1.12.2 version will be like that? You will not going to resolve RAM problem?((

iChun commented 5 years ago

I might, when I have time. At the moment I am busy with other things IRL.

On Thu, 6 Jun 2019, 12:42 PM shoverno2, notifications@github.com wrote:

Well, does 1.12.2 version will be like that? You will not going to resolve RAM problem?((

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/188?email_source=notifications&email_token=AARRETDL6EY4ALSBP2NDI5LPZCIRXA5CNFSM4HTQ4F22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBWTIQ#issuecomment-499345826, or mute the thread https://github.com/notifications/unsubscribe-auth/AARRETAJEKSVTN3ZJ6HI5GLPZCIRXANCNFSM4HTQ4F2Q .

iChun commented 5 years ago

If you're able to identify the cause for excessive RAM use then you can let me know the issue to help me track it down in the future or fix up the code yourself and submit a pull request.

On Thu, 6 Jun 2019, 12:49 PM Kay Vin Tee, ohai.ichun@gmail.com wrote:

I might, when I have time. At the moment I am busy with other things IRL.

On Thu, 6 Jun 2019, 12:42 PM shoverno2, notifications@github.com wrote:

Well, does 1.12.2 version will be like that? You will not going to resolve RAM problem?((

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/iChun/iChunUtil/issues/188?email_source=notifications&email_token=AARRETDL6EY4ALSBP2NDI5LPZCIRXA5CNFSM4HTQ4F22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBWTIQ#issuecomment-499345826, or mute the thread https://github.com/notifications/unsubscribe-auth/AARRETAJEKSVTN3ZJ6HI5GLPZCIRXANCNFSM4HTQ4F2Q .

shoverno2 commented 5 years ago

If you're able to identify the cause for excessive RAM use then you can let me know the issue to help me track it down in the future or fix up the code yourself and submit a pull request. On Thu, 6 Jun 2019, 12:49 PM Kay Vin Tee, @.> wrote: I might, when I have time. At the moment I am busy with other things IRL. On Thu, 6 Jun 2019, 12:42 PM shoverno2, @.> wrote: > Well, does 1.12.2 version will be like that? > You will not going to resolve RAM problem?(( > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <#188?email_source=notifications&email_token=AARRETDL6EY4ALSBP2NDI5LPZCIRXA5CNFSM4HTQ4F22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXBWTIQ#issuecomment-499345826>, > or mute the thread > https://github.com/notifications/unsubscribe-auth/AARRETAJEKSVTN3ZJ6HI5GLPZCIRXANCNFSM4HTQ4F2Q > . >

Well, i don't know everything, but this mod try to do something whith data, alots of data. Why not to add some sort of cleaner, couse mode already (without any other mods) try to use alots of ram uncontrollably. So, that's why i suggested to add config to off many non useful processes. For example: Does mod "Clef" using hard coded render or somthing greatly at RAM cost?

iChun commented 4 years ago

Java has it's own garbage collector which collects resources which aren't used anymore to free up memory. As mentioned I will not be tackling the issue for 1.12.2. I have suspects and I have put options in to disable them. A refactor is slated for 1.13+