search

iChun / iChunUtil

iChunUtil as required by several of my mods.
GNU Lesser General Public License v3.0
40 stars 53 forks source link

Fix weird tabula rotation controls & rotation point #94

Closed Distjubo closed 3 years ago

Distjubo commented 9 years ago

I replaced the model for the rotation point with a proper sphere, and I replaced the rotation controls with a torus model. Look at the screenshot below. 2015-07-03_11 51 44 By the way: If that torus is still not smooth enough, you can increase its resolution.

Distjubo commented 9 years ago

Won't anyone be automatically notified? Do I have to write something like @iChun to make him see this?

iChun commented 9 years ago

Uhhh you do realise I'm a bit too busy being at Minecon right now, right? :/ On 4 Jul 2015 4:53 PM, "Distjubo" notifications@github.com wrote:

Won't anyone be automatically notified? Do I have to write something like @iChun https://github.com/iChun to make them see this?

— Reply to this email directly or view it on GitHub https://github.com/iChun/iChunUtil/pull/94#issuecomment-118525493.

Distjubo commented 9 years ago

Uhh, no, sorry, I didn't even know what minecon is until I googled it just now :/ Sorry if you felt offended by the first comment :(

iChun commented 9 years ago

No worries man. But yeah for the moment I'm a bit too busy to be able to check PRs and all. On 4 Jul 2015 6:36 PM, "Distjubo" notifications@github.com wrote:

Uhh, no, sorry, I didn't even know what minecon is until I googled it just now :/ Sorry.

— Reply to this email directly or view it on GitHub https://github.com/iChun/iChunUtil/pull/94#issuecomment-118536599.

Distjubo commented 9 years ago

Lol, I derped up this PR too. Look at ModelRotationPoint, I have two parameters in the constructor with the arguments ignored. I am such a derp xD

Distjubo commented 9 years ago

Sorry, I can't fix this right now, I'm on a vacation for 3 weeks. If you want to, you can pull what I got and either way leave it like that or fix it (its not a big deal, should be rather easy)

iChun commented 9 years ago

Heh, no worries. I'm getting back into dev slowly, I'll take a look see when it's time to mess with iChunUtil again

iChun commented 9 years ago

Sorry for the very slow response though however. I do however like the controls, they look nice! :)

Distjubo commented 9 years ago

Hey dude I just came back from my vacation. BTW you might want to enable lighting before rendering the new controls to see what its REALLY doing. The base circle (if you cut one slice out of the donut) of the torus is not really a circle, its a square :P And you might want to decrease the resolution of the sphere because its not really necessary to render it any fancier without lighting.

Distjubo commented 8 years ago

just edited the latest commit to fix those rotationpoint arguments being ignored