Added New Refactored getGuardSetExpression

BrookFeleke commented 2 weeks ago

Description

I have added a new refactored version of the getGuardSetExp named getGuardSetExpression that uses superpose to increase performance and run in parallel. The new function is I haven't removed the old function since it is used in the module zero-constraint-subsumption.metta.

Motivation and Context

reduces the overhead of using car-atom and cdr-atom for iteration over the atom one at a time.
have better performance if done in parallel.
It closes issue #132
How Has This Been Tested?
all previous test scripts pass
additional tests have been added to cover the new function added
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

BrookFeleke commented 1 week ago

@BrookFeleke why can't you refactor the usage of getGuardSetExp in the zero constraint subsumption too like you did in the delete Inconsistent handle? Then remove the getGuardSetExp and change the name of your function to that?

I have made the requested changes and removed the old getGuardSetExp.

Yagth commented 1 week ago

Hey @BrookFeleke, just merged another PR and your code isn't working all of a sudden. I believe it a simple conflict that can be resolved on your side.

BrookFeleke commented 1 week ago

Hey @BrookFeleke, just merged another PR and your code isn't working all of a sudden. I believe it a simple conflict that can be resolved on your side.

Yes @Yagth it was because the new isConsistentExp was using the older version of getGuardExp with 3 arguments, i have changed that and it passes all tests now.

iCog-Labs-Dev / metta-moses