search

iConomy / Register

API for all major bukkit Economies for simplicity, Watch this for updates! - Supports iCo4, 5 & 6, BOSE 6 & 7, Essentials ECO 2.2.17
http://bit.ly/RegisterMethod
40 stars 15 forks source link

iCo6 Fix #6

Closed Maeyanie closed 13 years ago

Maeyanie commented 13 years ago

com.iCo6.IO is a package, not a class, so trying to create one will always fail.

Not sure what that's trying to do anyhow... certainly the next line does the check fine.

thdxr commented 13 years ago

I had to do this as well. Doesn't work without it.

LRFLEW commented 13 years ago

I don't think I could get iConomy6 to load at all on my server :P

It is a work in progress :P

Maeyanie commented 13 years ago

It is, but at least this gets it working in Register. Which should really be done as early as possible so those plugins claiming iCo6 support actually have it.

nijikokun commented 13 years ago

That makes sure it exists.

Maeyanie commented 13 years ago

That's the problem. There is no class named "com.iCo6.IO" in iCo6, so making sure it exists will always fail, even when iCo6 is installed and active.

There is a package by that name with two classes and a few sub-packages. But you can't instantiate a package, so can't check if it exists like that.

So, for Register iCo6 support to actually function, this check has to be either changed to an actual class (like com.iCo6.IO.Database) or removed and let the next line take care of it.

But I can't re-open this, and you probably won't bother reading a closed pull request, so I guess you'll have to discover that on your own. :)

LRFLEW commented 13 years ago

well, he pulled my version, and I implemented this, so in a sense, he pulled this :P.

Maeyanie commented 13 years ago

Long as it works, good enough for me. Thanks. :)