iDerp / Pi-Hole-for-LaMetric

Show your Pi-Hole status right on your LaMetric!
GNU General Public License v3.0
17 stars 3 forks source link

Lametric queries lametric.b1nzy.xyz every 5 seconds with plugin installed. #6

Closed malmentm closed 5 years ago

malmentm commented 5 years ago

Lametric queries lametric.b1nzy.xyz every 5 seconds with plugin installed. Is it necessary?

iDerp commented 5 years ago

I will fix this to pull every minute instead of every 5 seconds.

On Nov 5, 2018, at 13:54, malmentm notifications@github.com<mailto:notifications@github.com> wrote:

Lametric queries lametric.b1nzy.xyzhttp://lametric.b1nzy.xyz every 5 seconds with plugin installed.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/iDerp/Pi-Hole-for-LaMetric/issues/6, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOeLWIGUc7zkeK8o1Sx-uXtcypiJHctsks5usIlQgaJpZM4YPDFJ.

malmentm commented 5 years ago

Whats is it pulling every 5 sec?

iDerp commented 5 years ago

It's currently pulling new data every 5 seconds, which is a bit overkill

On Nov 5, 2018, at 13:57, malmentm notifications@github.com<mailto:notifications@github.com> wrote:

Whats is it pulling every 5 sec?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/iDerp/Pi-Hole-for-LaMetric/issues/6#issuecomment-435992747, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOeLWBVcTvbnAR8QKXzRvmlbGThoel9cks5usIojgaJpZM4YPDFJ.

malmentm commented 5 years ago

Can you make it an option so we can Control how often it will pull new data?

iDerp commented 5 years ago

That is set on the app side, it can't be changed by the user

On Nov 5, 2018, at 13:59, malmentm notifications@github.com<mailto:notifications@github.com> wrote:

Can you make it an option so we can Control how often it will pull new data?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/iDerp/Pi-Hole-for-LaMetric/issues/6#issuecomment-435993670, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOeLWIjqG763MLfO4UGIyzPWCPREXEDAks5usIqigaJpZM4YPDFJ.

malmentm commented 5 years ago

I noticed also that Latest blocket Query also shows [OBJECT OBJECT]

iDerp commented 5 years ago

I'll be sure to fix that for the update also

malmentm commented 5 years ago

Will you also change "Today" to "Last 24hrs" ?

iDerp commented 5 years ago

Sure!

malmentm commented 5 years ago

Can you also change the text displayed on the lametric to "Past 24 Hours" for DNS Queries, ADs Blocked and Total Client Seen? PiHole now reports stats in the form of last 24 hours and does not reset every midnight :)

"XXXX ADS BLOCKED IN THE PAS 24 HOURS" "XXXX DNS QUERIES IN THE PAST 24 HOURS" "XXXX CLIENT SEEN IN THE PAST 24 HOURS"

iDerp commented 5 years ago

Sure, I can do that from the server side so no update will be needed for that

malmentm commented 5 years ago

Ok, well I don't really know what looks best I might look better with just "XXXX ADS BLOCKED" "XXXX DNS QUERIES" "XXXX CLIENTS SEEN" As this is what the PiHole GUI shows. Or what do you think? We already knows this is for the past 24 hours as this is how PiHole works. (Past 24h) is ju redundant information :)

malmentm commented 5 years ago

Could you change to ..

"XXXX ADS BLOCKED" "XXXX DNS QUERIES" "XXXX CLIENTS SEEN"

I think less text is important on the lametric. Short and effective :) And it matched how the PiHole WebGUI displays the data