Closed schmidt9 closed 8 years ago
You know the status bar is handled completely differently from iOS 7 by Apple. Already, as I can not do the test on iOS 6, I give you an answer for iOS 7 ++:
Embed your table view controller in a navigation controller, and in the navigation controller scene, uncheck "Shows Navigation Bar":
What is Hotspot?
This flag is unchecked. Maybe problem is in my code bacause of manual frames adjusting... I'll check this
for iOS 6 we can do following fix as an workaround, because iOS 6 seems not to respect aligning to top layout guide (y = 20px) and it gives frame.origin.y = 20
on iOS 6, while on 9.3 it gives 0.
And if hotspot is active y = 40.
Hotspot is internet sharing from phone via WiFi or USB. Extra line 20px appears under status bar, if it is active.
- (void)perform
{
NSString *identifier = self.identifier;
PBRevealViewController *rvc = self.sourceViewController;
UIViewController *dvc = self.destinationViewController;
CGRect frame = dvc.view.frame;
frame.origin.y = 0; // fix for iOS 6
dvc.view.frame = frame;
if ([identifier isEqualToString:PBSegueMainIdentifier]) {
[rvc addChildViewController:dvc];
[dvc didMoveToParentViewController:rvc];
rvc.mainViewController = dvc;
}
else if ([identifier isEqualToString:PBSegueLeftIdentifier]) {
rvc.leftViewController = dvc;
}
else if ([identifier isEqualToString:PBSegueRightIdentifier]) {
rvc.rightViewController = dvc;
}
}
Hi @schmidt9 ,
Can you test these changes with the 6.0 version of iOS and keep me informed? Still missing rotation.
I found an iPhone 4 running iOS 7.1.2. I'll try to make a downgrade to iOS 6.
I think you could make a new branch and apply changes for iOS 6 there, if you do not want change master, this way I could see what changes exactly you made, then you could merge this branch into master
Yes, but in the files I sent to you, there is a // TODO comment for all changes.
Ok, I'll check it
Hi @schmidt9 ,
Do you code in Objective-c or Swift? Do you use CocoaPods for PBRevealViewController or not?
Because I'am doing some tests with a device on 7.1.2, and if I do not use CocoaPods, all is OK, but if I use it to integrate PBRevealViewController in a project, I get the error:
dyld: Symbol not found: _OBJCCLASS$_UIBlurEffect Referenced from: /var/mobile/Applications/6EFBFB6A-1B18-401E-980E-BD3FFAD2C2D3/Example3Swift.app/Example3Swift Expected in: /System/Library/Frameworks/UIKit.framework/UIKit in /var/mobile/Applications/6EFBFB6A-1B18-401E-980E-BD3FFAD2C2D3/Example3Swift.app/Example3Swift
I don't use CocoaPods, so I cannot say what's wrong there, sorry. I use Objective C.
Currently have not much time to test code on iOS 6, hope to make it soon
Ok, thank for reply. ++
Hi @schmidt9 , I worked on iOS 6. When you have some time to test, I expect your feedback...
This is a sample project:
Ok. Could you say what exactly to test?
The sample I posted and after your app but when you have time.
I tested your project, everything seems to work
I have not tried it in my app yet, maybe next days
Thanks a lot!
Hello @iDevelopper I tested class from the sample project in my app, it works as expected, will you merge these changes to main branch?
Hello @schmidt9 , Yes, I await your response. I'll do it this afternoon.
Done, pushed to master branch.
Thank you much!
Strange offset on iPhone 4s, iOS 6 (if hotspot is active, menu goes another 20px down)
On iPhone 6s (and other), iOS 9.3