iDigBio / ridigbio

ridigbio -- an R interface to iDigBio's API (see http://www.idigbio.org/)
http://idigbio.github.io/ridigbio/
Other
16 stars 10 forks source link

Failure with dev version of testthat #25

Closed hadley closed 8 years ago

hadley commented 8 years ago
checking tests ... ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:
  !is.null(df[1, "data.ac:accessURI"]) && df[1, "data.ac:accessURI"] != "NA" isn't true

  3. Failure (at test-idig_top_media.R#31): (unknown) ----------------------------
  top$itemCount > 0 isn't true

  testthat results ================================================================
  OK: 106 SKIPPED: 0 FAILED: 3
  1. Failure (at test-idig_count_media.R#19): (unknown) 
  2. Failure (at test-idig_search_media.R#36): (unknown) 
  3. Failure (at test-idig_top_media.R#31): (unknown) 

  Error: testthat unit tests failed
  Execution halted
DONE
Status: 1 ERROR

I'm planning to submit to CRAN this afternoon, so you may want to prepare a new release in the near future. Not sure why this didn't come up in my first round of tests.

mjcollin commented 8 years ago

Dupe of #22, not testthat related; proceed with your development as normal.

Thank you for checking my package.