search

iExecBlockchainComputing / iexec-apps

Dockerfile of all iExec apps
18 stars 23 forks source link

adding Bounty #3 - Bitcoin Transfer Verifier DOracle app #18

Closed j48 closed 5 years ago

j48 commented 5 years ago

used PriceFeed as a template was unable to test using dataset for APIKEY but blockchain.info doesn't require an api key (yet?) so it's not a big deal for now. wasn't sure how far to go with the data validation so I just assumed the returned API data will be correct 100% of the time. used switches because I thought of incorporating other API functions such as address balance but soon realized it's best to code to dapp/user requirements vs a full suite API app to keep the smart contract as simple as possible

Amxx commented 5 years ago

Hi @j48,

Thanks for submitting your pull request. Sorry for the delay reviewing it, we were all pretty busy these days.

So I looked at your code, and first of all congrats on your PR, that’s overall a great job. Here is my feedback:

  1. Thanks for the readme, that's much appreciated!

  2. Code is sometimes awkward and not easy to review. [NICE TO FIX]

  1. Lint your JS code to make easier to read [NICE TO FIX]

As soon as you provide us with a link to a run of your oracle on Kovan network, the bounty is yours! Of course, let us know if you encounter any problem.

What’s next? 4 front-end bounties will be announced, so that you can build a nice interface on top of your oracle smart contract (ex: this price feed frontend https://price-feed-doracle.iex.ec/)

So stay tuned on our Twitter to see the announcement.

Best, Hadrien

j48 commented 5 years ago

Thanks for the suggestions and advice. I'll fix up my code by the end of the day. I'll update here when I get it up on kovan.

app kovan address: 0x0b57bcD76572bD07AbF16109246e7AC24649D44d doracle kovan address: 0x4Fc4712508aBa5bA42ba32742a1108f297D08326

link of oracle app running: https://v3.explorer.iex.ec/kovan/deal/0xb3e1904212f670695d9b94a736be7bdf4a9830777b7de70a57611754c1907f97

link of oracle smart contract function processResult: https://kovan.etherscan.io/tx/0x01920ac3715924894b8b877e5aefec24d132ea391c831d3b8a1ef50e871a59c0#eventlog

I'll keep an eye out on twitter for the the front-end announcement. This was a lot of fun. Learned a lot about solidity(but still not that much lol) and brushed on my js.