search

iExecBlockchainComputing / iexec-apps

Dockerfile of all iExec apps
18 stars 23 forks source link

Build: Completed Bank Card Payment Validator #31

Open emmaodia opened 5 years ago

emmaodia commented 4 years ago

@sulliwane Kindly review my PR. Thanks.

emmaodia commented 4 years ago

App code is mostly clean, but I fell like this is probably not working:

  • JS Packages are not installed in the dockerfile
  • Envvar are not set (might require a dataset)
  • Output format is not capturing the response provided by the Web2 api.

Also, no smart contract is present to show how this can be processed onchain. There is no link to any run of this app on kovan. Was it tested at all?

It's a good first step, but it's not yet ready.

Thank you @Amxx for the review. I will work on the changes you suggested. The env vars will use dotenv to be served up so as not to expose private credentials to the public.

sulliwane commented 4 years ago

@emmaodia Hey! We will close the bounties end of this week. If you want to have a chance to win, please fix the issues raised by the reviewer! Thanks!

emmaodia commented 4 years ago

Update made: https://github.com/emmaodia/iexec-apps/commit/e64158d70d99cbfdc9ac51abf1340606b8341c13

@Amxx @sulliwane Thank you.