search

iFargle / headscale-webui

A simple Headscale web UI for small-scale deployments.
Other
627 stars 57 forks source link

Fix environment validators #89

Closed MarekPikula closed 1 year ago

MarekPikula commented 1 year ago

This should fix the issues with BUILD_TIME and AUTH_TYPE validation.

Please double-check if it works before releasing it – especially the modification in Jenkinsfile. It should work by looking at https://stackoverflow.com/a/50095241/2929726, but I have no means to test it.

Should fix #88

MarekPikula commented 1 year ago

BTW, why do you use Jenkins for building the images instead of GitHub Actions? It would make it much easier to debug ad integrate the building in (possibly) integrated CI tests in the future. GitHub Actions have really nice infrastructure for building Docker images. If you wish, I could look into that.

iFargle commented 1 year ago

it's just what I'm familiar with :) I'd gladly move to Github Actions, just need time to learn it