iFixit / alertinator

Simplistic team-based alerting through email, sms and phone calls.

http://alertinator.readthedocs.org/

Other

9 stars 4 forks source link

Connect to conference call after the message #19

Closed sterlinghirsh closed 4 years ago

sterlinghirsh commented 4 years ago

If you stay on the phone call after the error message is read, you'll be asked to press a digit. If you do, you're connected to a conference call with everyone else.

QA

Test https://github.com/iFixit/ifixit/pull/33279. (This is a dependency of https://github.com/iFixit/ifixit/pull/33279 and testing that will test this.)

Connects https://github.com/iFixit/ifixit/pull/33279

djmetzle commented 4 years ago

That's it? CR :gear:

sterlinghirsh commented 4 years ago

I know right? I'm working on a few more quality of life fixes that I'm going to put in here too.

djmetzle commented 4 years ago

CR :exclamation:

addison-grant commented 4 years ago

Are you opening a corresponding PR on iFixit/ifixit? Could we modify the fakeAlert script to take in multiple phone numbers?

jarstelfox commented 4 years ago

CR 🌵

sterlinghirsh commented 4 years ago

Changed it so you have to press a digit because it kept connecting to people's answering machines on the conference call. Slightly more work but much better result.

djmetzle commented 4 years ago

CR :phone:

jarstelfox commented 4 years ago

CR 🌵

sterlinghirsh commented 4 years ago

I added the 1 second pause.

jarstelfox commented 4 years ago

CR 🌵

djmetzle commented 4 years ago

CR :pause_button:

batbattur commented 4 years ago

Tested https://github.com/iFixit/ifixit/pull/33279#issuecomment-645609934 and worked nicely.

QA 👍