search

iFixit / charge

A tool to upload static images for the site
3 stars 2 forks source link

Enable uploading to s3 #8

Closed djmetzle closed 5 years ago

djmetzle commented 5 years ago

Do the thing! Let's implement and (safely) allow enabling live S3 uploads! :tada:

The acl and cache-control params for the put-object call are a little bit hardcoded for now, but these settings are exactly what we want for now.

For safety, i've made stubbing out the S3 service the default. If we want to really do thing, we've got to do it intentionally.

Closes: https://github.com/iFixit/charge/issues/4

CC @danielbeardsley

danielbeardsley commented 5 years ago

CR 👍

I think we want to do it intentionally, right?

djmetzle commented 5 years ago

@danielbeardsley

I think we want to do it intentionally, right?

I think it's probably safest for now to turn on the uploading when we really mean it, then make it the default later...

tvillarete commented 5 years ago

CR 🚦

djmetzle commented 5 years ago

Derp. Dev block. Found bugs in QA.

djmetzle commented 5 years ago

un_dev_block :thisisntonpulldasher: :stuck_out_tongue:

Made a bunch of fixes, and this is good to go. QA :+1:

jarstelfox commented 5 years ago

CR 🌵