search

iFixit / css-gather

Fetches all the CSS files off a page and dumps their CSS to stdout
MIT License
2 stars 0 forks source link

Manually set preferred store #13

Closed batbattur closed 1 year ago

batbattur commented 1 year ago

Summary

Sometimes when we run critical-css.yml, the preferred store is set to DE instead of US. See more at https://github.com/iFixit/ifixit/pull/47892#issuecomment-1550070719.

Let's try manually setting the US store by sending POST request to store/user/store_preference (https://github.com/iFixit/ifixit/pull/47892#issuecomment-1550095750) when we start penthouse here.

Background

https://github.com/iFixit/ifixit/pull/47892#issuecomment-1550070719 and https://github.com/iFixit/ifixit/pull/47892#issuecomment-1550095750

mlahargou commented 1 year ago

Has this caused issues recently?

batbattur commented 1 year ago

I just checked the screenshots from the last 2-3 weeks' weekly updates and confirmed that all of them have US store set.

I think this can be a very low priority or stay in the backlog.