search

iFixit / css-gather

Fetches all the CSS files off a page and dumps their CSS to stdout
MIT License
2 stars 0 forks source link

Add exclude option for penthouse `forceExclude` config #9

Closed batbattur closed 1 year ago

batbattur commented 1 year ago

Summary

Added option to exclude certain css selectors from the critical css using the forceExclude option in penthouse.

QA notes

We can run the critical-css.yml workflow from the iFixit/ifixit side (with this branch specified) to verify it still works. qa_req 0

connects #47316

batbattur commented 1 year ago

QA 🚛 tested the changes in https://github.com/iFixit/ifixit/pull/47367#issuecomment-1505796048

batbattur commented 1 year ago

dev_block 🚛

batbattur commented 1 year ago

deploy_block 🚛 on https://github.com/iFixit/ifixit/pull/47367 getting CR-ed un_dev_block 🚛 fixed https://github.com/iFixit/css-gather/pull/9#discussion_r1165975217 in https://github.com/iFixit/css-gather/pull/9/commits/89f826b2ee03e83ac613e1d0e8d9cd24c9624e47

Steps used to test:

  1. Before excluding any elements from the critical css, confimed that #mainBody css exists. Screen Shot 2023-04-13 at 5 44 34 PM
  2. Then ran the run.rb script with --exclude=/mAiNbOdy/gi option: ./run.rb https://www.ifixit.com/ --exclude=.skip-to-content --exclude=/mAiNbOdy/gi --exclude=/invalidregex > after
  3. Then verified that passing regex with gi flags works properly now. Screen Shot 2023-04-13 at 5 44 54 PM|

QA 🚛

batbattur commented 1 year ago

un_deploy_block 🚛 the pull on iFixit/ifixit side got reviewed