Kyle's Android Bug Roundup

General:

[ ] We need to inject delight. This app should be fun to use. Right now it's functional, but it doesn't get me excited about making a new guide. Fades, animations, some photos on open, etc. When empty, my guides could be a place for a fun image, as would Media Manager.

Create guide:

[ ] Is there any way we could include the camera metadata in the EXIF, or a tag that shows the photo was taken from the iFixit Android app? Could be useful on image metadata.

Patrol:

[ ] Make an edit to a guide that will be patrolled. View the guide. Your changes are not shown. Fix: we should show the bleeding edge, unapproved version of a guide once you've started making changes. (Or maybe all the time? Or maybe we need this switch in the app?)

View Guide:

[ ] Introduction view needs a background image, or something other than a white background
[ ] Guides section for devices w/o guides yet says 'No guides' Can we invite them to start one now?

Guide intro:

[ ] Intro and tools display pages are very plain—perhaps a background image like iOS or a graphic from Tony?
[ ] On simple guides with just a few tools, you end up with blank intro, blank tools page, no indication there's anything good coming
[ ] I don't think parts and tools shouldn't be two separate pages. You're never going to fill up both lists, and it's a whole lot of scrolling to get to the interesting part of a guide.

Fixed:

[x] No indication you need to slide right on the intro, view tools, or step page.
[x] Video plays upside down
[x] ~~Make changes to a step, but don't save. Click Discard Changes. Error: Guide not found.~~ 6d7e765
[x] ~~Nix 'introduction' and 'review' when you're creating a guide the first time. Not necessary.~~ ed3b7c12117ab52bba7eb5cd35bc554a8103cda0
[x] Viewing photos: in media manager or guide edit, on the Nexus 10, when I tap on an image to see it big it only fills 1/3 of the screen. I want it bigger! -- Fixed with 4448d11c74f88a4385f408463fb52781610d92fc
[x] ~~On guide, tap favorites to go to login screen, landscape. Rotate to portrait. Crashes.~~ fixed with d14e74dbd4c5606b987b4acac915b188fa5fca41
[x] ~~On login screen, rotate tablet. Loses all input to that point. (This can be OK, but it's slightly annoying)~~ Not able to reproduce. Fixed with d14e74dbd4c5606b987b4acac915b188fa5fca41 i'm guessing.
[x] You can exceed the bullet text length limit of 350 characters. -- Unable to reproduce, it stops me at 350.
[x] Let's not show the 'Step title' field on the very first step of a new guide. Only show it after that. You should never title that step anyway. -- Fixed with cb5537ca1fdcdc89d057e2eb6dcbd7bb840808d3
[x] ~~'Add new bullet' -> 'New line'~~ bd10d11
[x] ~~On the list of 'my guides', when you have a very long list, it seems like one out of every 20 or so is 'unfolded' so you can see the buttons. Scrolling, you can see these buttons at regular intervals.~~ -- Fixed with ec45a56546f7749089662bc4ddbe9a37d2ea7c9d
[x] You can type newlines in bullet text—this shouldn't be allowed.
[x] Crashed taking guide photo
[x] Issues with photos saved to a step disappearing, inconsistencies with photo edit interface
[x] Create a new step, add an image. Put a space as your new line, and save. You get a validation error, and clicking try again just shows the error. (I would expect the error message to go away so I could edit.) Tapping outside of the error message dumps you out of the guide.
[x] You can type newlines in the Device name, subject, etc.
[x] Tablet video doesn't play full screen - e0089f799657624216edc2f057189108a571b113
[x] Google sign in isn't working. I authenticate with google, and I just end up back on the login screen - 9103dc0cd9989c38fc3009b5638e98ce776cdf63 and b39c73d53b48a69af0ceaa60f9671cf578cfd043
[x] If you do something bad in the process of creating a guide, you get a 'Validation failed' error over and over with no way to fix it.
[x] Click publish. It takes a second, so tap it again. You get an error that the state is inconsistent. It should probably not let you tap again until a response has been received, and it would be good to show the user that we're doing something. 9f6a50a78f3f0cf03de02f73d8392a02c0d53d62
[x] How does publish / unpublish work with patrolling? -- Only users whose edits will be automatically accepted are allowed to make changes to guide privacy.
[x] CRITICAL: Use an unprivileged user. Make an edit to a high-privilege guide, then go over to My Guides. Unpublish it. The unpublish flag change is held in the patrol queue, but the guide is still marked as private. This is bad. (Denying the edits republishes it, but it's too late.) -- Fixed server-side by disabling patrolled privacy changes.
[x] Ford is listed as a device, not a category. Different from the iOS app.
[x] What's the purpose of the reload guide button? It should at least have some visual feedback that it's doing something. See #121
[x] 'Device name' -> Should this be 'Start a new guide'?
[x] 'Finish' -> 'Get started'
[x] 'Media Manager' -> 'iFixit Media' (otherwise, it could be android photo gallery) -- Media Manager is the wording we use on the website? The android photo gallery is called "Gallery", I'm not convinced that they would be confused?
[x] Can we add a big voice dictation button on the line editor somewhere?
[x] Perhaps you should close the keyboard when you save a step. Otherwise, it's not obvious what to do next.
[x] If I don't like a photo I just took, how do I remove it from a step? -- Long tap the image and an options menu will show up to remove, copy or detach to media manager.
[x] When you have an empty media manager, the error is 'No images in your Media Manager. Add images with the icons above!' There are no icons above.
[x] On complex steps (like a teardown), switching between steps in edit mode stutters, even when the images are already cached. It would be nice to make this smoother.
[x] There's no obvious way to publish a guide when I'm done with it! I have to go back over to 'My Guides', then find the publish button.
[x] I got four photos on a step. Took three phtoos, tapped on the left one, and it let me take another. It went on there to the right of the third photo, but wouldn't let me save. --- Can't reproduce, any ideas?
[x] Bad capitalization of iFixit: "This media manager is linked directly to your Ifixit account."
[x] Put the Device Name first, above guide type
[x] It's not obvious that you swipe to go from one step to the next
[x] When you take photos upside down on the nexus 10, they initially look correct, but then flip upside down. We probably need to pay attention to the orientation metadata on the server upload. I suspect we'll have similar issues with images rotated in Preview. (Fixed by respecting orientation EXIF data server side)
[x] I get 'Your changes couldn't be saved because the content has changed' a lot more than I should. I think Edit step isn't refreshing as often as it should be. (I haven't gotten this erroneously in a while. Uncheck this and move it to the top if it's reproducible.)
[x] The iOS app doesn't show In Progress guides. That's probably a good idea here, too. Except that new guides created from the app will have the in progress flag on them. This actually isn't true. The iOS app does display In Progress guides. We don't want to remove them because there is still good content in In Progress guides.
[x] Save and cancel are alternately on different sides of confirmation modals. Standardize. I'd suggest 'Save?' No: Yes. everywhere, but open to suggestions. I made a quick pass on our dialogs and they all seem consistent since they all call setPositive and setNegative.
[x] New guide details -> What are you working on? / Device Name -> Device / Guide Type / Type of guide
[x] What kind of logging do we have of edits from the app? There is an open pull to log all API edits and the UserAgent that made them.
[x] There's no way to ever remove the In Progress flag from an Android guide. Maybe that's OK for v1. Flag editing will be done in v2.
[x] Disable google translate via API on different locales, for now. (When my site profile is set to German, I get content in german. But then I could save German text to English, which would be a bad thing.) -- This isn't an issue anymore now that there is a separate toggle for machine translation of user generated content which will never be on for API consumers.

iFixit / iFixitAndroid

Kyle's Android Bug Roundup #109