search

iFixit / iFixitAndroid

Official iFixit Android App
https://play.google.com/store/apps/details?id=com.dozuki.ifixit
GNU General Public License v3.0
162 stars 88 forks source link

Crash on logout when DeadEvents exist #147

Closed timothyasp closed 11 years ago

timothyasp commented 11 years ago

APIService should listen for logout and clear out the deadevent list so we don't retry events that require authentication.

marczych commented 11 years ago

We decided to not clear out dead events on logout because:

  1. Some of them might still be useful (unauthenticated Activities lower on the stack).
  2. They aren't causing crashes because the requests aren't being retried -- the events containing the request responses are being posted to the Bus again.

However, we decided to compare the current logged in userid with the userid associated with the Activity and deny access if they didn't match and the Activity requires authentication: c5339c2efa1b876bc79be1e03152969f550ea58e.