Guide and Category Search

[timothyasp]

This pull implements search throughout the app. Finally.

RIght now we just have search for categories (Topics, devices, whateverwecallthem) and guides. There is a search item in the menu drawer which takes you to the default search activity and allows you to perform a search there. Also, in TopicActivity and TopicViewActivity, there are search icons in the action bar.

These changes are deployed to both beta groups.

[danielbeardsley]

This is exciting!

[marczych]

Some issues I found during testing:

Clicking search from the menu drawer

• [x] After opening the search activity, it performs a search for an empty string.
• [x] Then the user must click on the magnifying glass to enter a search query. It should be automatically focussed if there isn't already a search query.

Search Activity

• [x] Endless scrolling doesn't work for multiple searches
  1. Search for something with very few results. I searched for lumia.
  2. Search for something that has lots of results. I searched for phone.
  3. There are 1000 results but you can only view the first page because it thinks it has reached the last based on the lumia search.
• [x] Guides search doesn't include teardowns. Apparently it's a different filter type in the API: teardowns vs. guides
• [x] Make sure the hardware search button works correctly.
• [x] Search box focus
  1. Open app.
  2. Click magnifying glass in top right.
  3. Close the keyboard.
  4. Navigate into a category. The search box gets focus and recent searches are displayed.
  5. To go back to the root category, you must hit back to remove focus from the search box, hit back to get out of the search context, and finally hit back once more to navigate back in the hierarchy.
• [x] The title of the search results activity is just the search query. Would Search: {query} be better? It looks like other apps, including the Play Store, have the same behavior so it's probably best to be consistent with them and leave it as-is.
• [x] Selecting a search suggestion doesn't populate the search view with that query. Closing the search view so the query is displayed as the title in the action bar would also be acceptable.

[marczych]

I'm really happy with the code on the whole. There is still at least one minor comment that hasn't been addressed yet, though.

I'm good to merge it after we fix/decide to not fix the issues I brought up earlier.

[timothyasp]

Hardware search works (albeit a bit ugly on 2.2).

[marczych]

Would it be possible to move App/res/xml/searchable.xml to App/sites/ifixit/res/xml/searchable.xml so every site has to specify one? This would also make it so we don't forget to make one for new sites since the ifixit directory is copied and modified.

Also, you need to merge in master and resolve the conflicts.