search

iFixit / iFixitAndroid

Official iFixit Android App
https://play.google.com/store/apps/details?id=com.dozuki.ifixit
GNU General Public License v3.0
162 stars 88 forks source link

Clean up menu code #156

Closed marczych closed 11 years ago

marczych commented 11 years ago

We aren't at all consistent with calling super or returning the correct value in the options methods e.g. onOptionsItemSelected. This makes it consistent with the examples in the Android docs.

marczych commented 11 years ago

This actually fixes a bug with in SearchActivity for iFixit. With the barcode scanning branch, the QR code icon is always displayed in SearchActivity because BaseSearchMenuDrawerActivity.onPrepareOptionsMenu() is never called to hide it.

I honestly didn't do much testing of this but I'm fairly confident that this will only fix obscure bugs like the one above. I say we do some testing of guide creation (since it's the the part of the app that most extensively uses menu items) and merge it.

marczych commented 11 years ago

I just tested guide edit, step edit, media manager, and search so I think it's good to go. Any objections to merging it, @timothyasp ?

timothyasp commented 11 years ago

No objections - merge it!