Add commenting to Guides / Steps

[timothyasp]

This adds commenting features to guide and step views.

Features:

• View all comments from the action bar
• Add a new comment
• Reply to existing comments
• View / Edit / Delete your comments

[timothyasp]

Just retested, and this is looking good after all the changes made in the API

[scotttherobot]

This is lovely -- except for reloading comments. If you load a guide on the device, then make a comment on the website, you'll be hard pressed to get the comment to show up in the app. The reload guide button doesn't seem to help. (I talked to @timothyasp about this in more detail).

Everything else looks good.

• You can only edit your comments for 5 minutes after they're created
• You can only delete your own comments
• You can only post comments if you have an active internet connection (otherwise a toast pops).
• Each step has its own distinct set of comments
• You can only post comments if you are logged in.

Nice work, @timothyasp!

[timothyasp]

@scotttherobot Fixed with dca056f

[marczych]

I can't leave a comment on an image diff so I'm leaving it here instead. We already have 2 overflow menu resources: ic_menu_moreoverflow_normal_holo_light and ic_menu_spinner. I don't think adding another one (ic_action_overflow) into the mix makes any sense.

In fact none of those are actually used... we probably have a lot of unused resources that we should removed.

[marczych]

I'm still going through it but here is my list so far:

Disabled comment box when logged out

1. While logged out, view some comments.
2. Type something into the comment box.
3. Hit the send button.
4. The login dialog pops up. Cancel it by hitting back or tapping outside of the dialog.
5. The comment box is disabled. However, the send button is still enabled so you can still send it after logging in.

Canceling the login dialog should probably enable the comment box.

• [x] Links aren't clickable although they appear as hyperlinks.
• [x] The comment menu item doesn't display a tooltip on long press. It's trivial to do with CheatSheet.
• [x] There is no way to add a top level comment after hitting Reply. You have to reopen the comments view to do so.
• [x] Hitting Reply puts focus on the comment text box but doesn't open the keyboard.
• [ ] Only 2 lines of the comment text are visible at a time. This might be an issue for longer comments. Actually, if you close the keyboard it expands to show all of the text and remains that height even if you open the keyboard again. Looks like closing the keyboard forces a redraw of the text box?
• [ ] Should we open the keyboard automatically if there aren't any comments?
• [ ] The comments menu item should be disabled if the guide isn't loaded yet.
• [x] There isn't a spinner when waiting for a comment to submit. Replacing the send button with a spinner makes sense to me.
• [x] Profile images look bad if the "no image" is displayed. Try it without internet. I guess I'm fine with it as-is if getting the circle transform on it isn't easy.
• [ ] Profile images aren't saved for offline viewing. I think that's fine.

[timothyasp]

Unfortunatly it's not possible to apply the transformations to the error image https://github.com/square/picasso/issues/337

We'd have to go with a whole new approach

[timothyasp]

Addressed the important bugs and usability concerns.

[marczych]

• [x] There isn't auto completion/correction on the text box.
• [x] The scrollbar changes size as you scroll through a long list of comments.
• [x] The comments menu should hidden if there aren't any actions to take on it.
• [x] Responding to a reply is only possible by clicking reply on the top level comment. Adding a reply button to each reply which does the same thing as reply on the top level comment makes sense to me.
• [x] The "Save" button on comment edit can be spammed. It should be replaced with a spinner like the add comment/reply button. 55125601c682c45109fcb319e6c0bdce94e58937
• [x] Posting a duplicate comment results in the comment box being disabled even though the send comment button is enabled.

Comment deletion

1. Delete a comment.
2. Change orientation. Notice how the spinner on the menu is gone.
3. Delete the comment again.
4. First API call comes back and the comment is removed.
5. Second API call comes back and results in a crash:

 Caused by: java.lang.NullPointerException
     at com.dozuki.ifixit.ui.guide.CommentsActivity.onCommentDeleted(CommentsActivity.java:216)
     at java.lang.reflect.Method.invokeNative(Native Method)
     at java.lang.reflect.Method.invoke(Method.java:515)
     at com.squareup.otto.EventHandler.handleEvent(EventHandler.java:89)
     at com.squareup.otto.Bus.dispatch(Bus.java:384)
     ... 16 more

[timothyasp]

Issues handled - thanks for the testing @marczych!

[timothyasp]

Merging...

[marczych]

• [x] On Dozuki, the title (" Guide Comments") is clickable but doesn't perform the same action as the caret. Search, which has similar functionality, has a similar issue except that it opens the menu drawer instead. The menu drawer probably shouldn't be available on search... 61d577b4128b616ecb0c4af720cf64f3c1798022
• [x] We should add analytics for any relevant commenting events. 8ad5435a9718eb6ab07f6b3c6278487c8da4fec0