search

iFixit / iFixitAndroid

Official iFixit Android App
https://play.google.com/store/apps/details?id=com.dozuki.ifixit
GNU General Public License v3.0
162 stars 88 forks source link

Guide completions and conclusion page #226

Closed timothyasp closed 10 years ago

timothyasp commented 10 years ago

Adds conclusion page to guide view and complete guide button.

MutantFreak commented 10 years ago

Let's change the completed state for the button to add an "!", so it says "Completed!" - as @kwiens says, we need to be injecting delight into our user experience.

I'd also like change the pre-completed state from "I completed this guide" to something more fun & engaging (at least for iFixit, maybe not so much for Dozuki). I think we should keep the same phrasing as we have on the website for both iFixit & Dozuki: iFixit: "I did it! Success!" Dozuki + nanosites: "Complete guide"

BaseInfinity commented 10 years ago

QA :bikini: Verified:

  1. Guide completion and website guide completion are in sync.
  2. Verified you cannot complete a teardown.
marczych commented 10 years ago

I'm ready to CR this after this comment has been addressed.

I also did decently thorough testing on a Galaxy Nexus on 4.4 (Cyanogenmod 11) for the iFixit app.

QA Checklist

marczych commented 10 years ago

I'm ready to CR this after this comment has been addressed.

Fixed with 63300c064f704f201359768439bb0f9d667f085a.

CR :cookie:

marczych commented 10 years ago

CR :dash: