iFixit / iFixitAndroid

Official iFixit Android App
https://play.google.com/store/apps/details?id=com.dozuki.ifixit
GNU General Public License v3.0
162 stars 83 forks source link

Google Login: Migrate to OAuth #250

Closed marczych closed 9 years ago

marczych commented 9 years ago

Google login through OpenID has been deprecated for a little while now so we have to migrate to Google OAuth. This results in a much better user experience because it goes through the native interface and doesn't require the user to enter their credentials.

This also increases the minSdkVersion to 9 which is android 2.3. This is required for Google Play Services which provides the Google Login functionality. Android 2.2 only makes up 0.65% of installs currently. It's unfortunate to lose them but the old app will still work for them.

QA

Closes #249

ghost commented 9 years ago

Tested on

I'm really not sure what would have changed after I added my personal account. It was working perfectly before.

marczych commented 9 years ago

The Nexus 9 and 7 worked fine with logging in through Google+ at first under the ifixitdev@gmail.com but when I tried to add my personal Google+ account the app would no longer allow me to log in through Google. Even after I removed my personal account. I would get an Invalid Login error.

That is weird. I added and removed Google accounts on my device without any problems. If you can reproduce it and show me that would be great.

The HTC Evo never actually successfully logged in through Google. I kept getting an error message stating that an error occurred while trying to load content from our servers.

I've been struggling with the same problems on the Evo. I'm pretty sure it's caused by the WiFi going in and out.

Also, I couldn't get the app to run at all on the Evo until cba3f3dc4a2b71fc74d07c3193d4018a4d84a1d9 so it'd be nice to double check that you're on the latest version.

timothyasp commented 9 years ago

Looks good! Nice work. CR :+1:

marczych commented 9 years ago

I did some quick testing on various devices with my last commit and everything looked good. @grantwhiting, are you happy with the app the last time you tested it?

timothyasp commented 9 years ago

CR :+1:

ghost commented 9 years ago

@marczych I tested it again on a few devices and it looks like it's working fine. I'm not running into any login limits.

QA :100: