search

iFixit / iFixitAndroid

Official iFixit Android App
https://play.google.com/store/apps/details?id=com.dozuki.ifixit
GNU General Public License v3.0
162 stars 88 forks source link

Usage of deprecated CookieSyncManager #279

Closed LiliWeiSE closed 6 years ago

LiliWeiSE commented 7 years ago

Hi,

I have found that CookieSyncManager is still in use in WebviewFragment and OpenIDActivity. According to the doc, it is deprecated since Lollipop so it may not guarantee to work.

A better implementation may be to use CookieSyncManager on lower API levels and use APIs of CookieManager to manage the cookies. I found a reference post in stack overflow here

Thx.

timothyasp commented 7 years ago

Thanks for the report, will take a look into this. Also, feel free to open a pull request with the changes! will be happy to merge them.