search

iFixit / iFixitAndroid

Official iFixit Android App
https://play.google.com/store/apps/details?id=com.dozuki.ifixit
GNU General Public License v3.0
162 stars 88 forks source link

Visible "Log In" link on internal browser doesn't integrate with app #46

Closed cedmans closed 9 years ago

cedmans commented 11 years ago

Between the initial app startup and going straight to a product Info page, there's no obvious login method in the app.

I tried logging in using the "Log In" link in the internal browser. (Because testing)

In landscape mode, the keyboard consistently covers needed textboxes for login info input. In portrait mode, it's only slightly better.

Once logged in, the app itself is unaware of that fact (such as after clicking the gallery button in the upper-right).

Repro:

  1. Start app while not logged in
  2. Visit a specific product info page
  3. Observe the "Log In" link in the upper-right of the internal browser, and try to use it to log in.
  4. Use the Gallery button in the upper-right of the app.
cedmans commented 11 years ago

Perhaps prevent the login link from appearing in the internal browser (via user agent string, maybe), or find some way of capturing that click attempt and using the app's login system.

In the first case, there should be a more obvious way to log in from inside the app than trying to use the gallery and learning you're not logged in.

cedmans commented 11 years ago

Closing; I'm not on the beta.

cedmans commented 11 years ago

Reopenning; That login button is still there in the beta.

xiongchiamiov commented 11 years ago

Perhaps prevent the login link from appearing in the internal browser (via user agent string, maybe)

Can you do similar things to what Stefan is doing in the iOS app and add custom css to the page to hide the login details?

timothyasp commented 9 years ago

Wont fix.