search

iFixit / react-commerce

A work in progress prototype for iFixit e-commerce functionalities.
https://react-commerce.vercel.app
2 stars 0 forks source link

Vulcan: Wrap pre elements #2209

Closed ianrohde closed 8 months ago

ianrohde commented 8 months ago

Issue

I saw an error div rendered on a Vulcan page that I hadn’t seen before: ifixit.com/Troubleshooting/Nintendo_Switch/Will+Not+Turn+On/481634

It's breaking the page layout because the pre elements don't wrap.

Pre-fix Details Screenshot 2024-01-16 at 3 53 47 PM

CR/QA

This issue was only present on the live site, but Shawn has since fixed the content issue (Slack ref). I have a video of the proposed fix being toggled, which should suffice:

Post-fix Details https://github.com/iFixit/react-commerce/assets/1634505/0ea5235a-a272-4fdb-a525-b57bb79af44c

Closes https://github.com/iFixit/ifixit/issues/51605

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 6:54pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 6:54pm
ghost commented 8 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/iFixit/react-commerce/2209/3e20dc00/bdf194b0b35299975b3303b013671528de399f7f.svg)](https://app.codesee.io/r/reviews?pr=2209&src=https%3A%2F%2Fgithub.com%2FiFixit%2Freact-commerce) #### Legend CodeSee Map legend
github-actions[bot] commented 8 months ago

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deltuh-vee commented 8 months ago

dev_block ✊ This fix doesn't work on Firefox or Safari on macOS.

I readded the breaking token to the page. https://react-commerce-git-vulcan-wrap-pre-elements-ifixit.vercel.app/Troubleshooting/Nintendo_Switch/Will+Not+Turn+On/481634

ianrohde commented 8 months ago

This fix doesn't work on Firefox or Safari on macOS.

Sorry I missed that 😞

Fixed in https://github.com/iFixit/react-commerce/pull/2209/commits/bdf194b0b35299975b3303b013671528de399f7f

https://react-commerce-ny0lxtyha-ifixit.vercel.app/Troubleshooting/Nintendo_Switch/Will+Not+Turn+On/481634

Details https://github.com/iFixit/react-commerce/assets/1634505/f62165b3-a436-491c-999d-3d12380a41f9

un_dev_block 🟢

deltuh-vee commented 8 months ago

QA 🎬 Page elements are now wrapping even with an error.