search

iFixit / react-commerce

A work in progress prototype for iFixit e-commerce functionalities.
https://react-commerce.vercel.app
2 stars 0 forks source link

Problems List: NavBar: Use new `deviceUrls` API values #2223

Closed ianrohde closed 7 months ago

ianrohde commented 7 months ago

Issue

We are adding API values for deviceUrls in https://github.com/iFixit/ifixit/pull/51857. Let's hook them up and enable the NavBar links.

CR/QA

Confirm the NavBar links are working as expected.

Note: not all devices have devicePartsUrl links, but everything should have guide links:

Details https://github.com/iFixit/react-commerce/assets/1634505/348c6ee0-1f98-4850-a4ac-cb8d9d92e8b0

Connects https://github.com/iFixit/ifixit/issues/51698

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview Jan 31, 2024 6:23pm
react-commerce-prod ✅ Ready (Inspect) Visit Preview Jan 31, 2024 6:23pm
ianrohde commented 7 months ago

deploy_block 🔴 on https://github.com/iFixit/ifixit/pull/51857 going out first

ghost commented 7 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/iFixit/react-commerce/2223/9dfd185a/af778ecaf327c5467f9ccfb17899c2c86dfd5b18.svg)](https://app.codesee.io/r/reviews?pr=2223&src=https%3A%2F%2Fgithub.com%2FiFixit%2Freact-commerce) #### Legend CodeSee Map legend
github-actions[bot] commented 7 months ago

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

ianrohde commented 7 months ago

un_deploy_block 🟢

ianrohde commented 7 months ago

Test failures are an unrelated timeout. I'll re-run them tomorrow

deltuh-vee commented 7 months ago

QA 🎬 Device URL links have been added to the Navbar. ❓ Could we not render the Parts button if there is no link? Or is there an alternative to having a slightly lighter grey? CleanShot 2024-01-31 at 10 04 33

ianrohde commented 7 months ago

❓ Could we not render the Parts button if there is no link? Or is there an alternative to having a slightly lighter grey?

We have an in-progress discussion about that. We'll be deciding on how to proceed soon 👍

kthaler commented 7 months ago

QA 💎 - Troubleshooting pages now have Device URL links in the navbar that correctly link to the relevant part. Troubleshooting pages for devices that don't have a devicePartsUrl link have a Parts link that is greyed out.