search

iFixit / react-commerce

A work in progress prototype for iFixit e-commerce functionalities.
https://react-commerce.vercel.app
2 stars 0 forks source link

Add app router troubleshooting page under feature flags #2235

Closed dhmacs closed 7 months ago

dhmacs commented 7 months ago

Part of https://github.com/iFixit/ifixit/issues/52003

qa_req 0

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-commerce ✅ Ready (Inspect) Visit Preview Feb 8, 2024 11:12am
react-commerce-prod ✅ Ready (Inspect) Visit Preview Feb 8, 2024 11:12am
ghost commented 7 months ago
👇 Click on the image for a new way to code review #### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/iFixit/react-commerce/2235/0a6fb44d/31a915d3e2bf6f567634e9ea24dde1098ffcf7ab.svg)](https://app.codesee.io/r/reviews?pr=2235&src=https%3A%2F%2Fgithub.com%2FiFixit%2Freact-commerce) #### Legend CodeSee Map legend
github-actions[bot] commented 7 months ago

📦 Next.js Bundle Analysis for @ifixit/commerce-frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

danielbeardsley commented 7 months ago

un_deploy_block :+1: I can still access troubleshooting urls and thus the pages router must take precedence.

https://react-commerce-prod-c7lte8ck7-ifixit.vercel.app/Troubleshooting/Steam_Deck/Touch+Screen+Not+Working/520934

danielbeardsley commented 7 months ago

must take precedence.

Hmm.. but if that's the case, what does the env var buy us as it's not changing the precedence order it seems?

danielbeardsley commented 7 months ago

Turns out, I missed that this new route starts with /app-router/Troubleshooting and thus is a separate route from the existing page. The env var helps by just hiding it in prod so it doesn't get seen or indexed.

un_deploy_block :+1: